feat(website): allow restricting which fields are allowed to be referenced in the AdvancedQueryFilter#1195
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Open
4 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Adds opt-in client-side enforcement for restricting which metadata fields can be referenced in the website’s Advanced Query (LAPIS) filter, enabling dashboards to constrain queries to an approved field set while keeping mutation-only queries unrestricted.
Changes:
- Introduces
allowedFields?: string[]configuration foradvancedQuerybaseline filters and wires it through to the AdvancedQueryFilter component. - Adds
extractMetadataFields()to walk a parsedSiloFilterExpressionand collect referenced metadata columns, enabling enforcement after successful LAPIS validation. - Adds unit tests for
extractMetadataFieldsand browser specs covering allowed/disallowed/mutation-only scenarios.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
website/src/lapis/siloFilterExpression.ts |
Adds extractMetadataFields() to collect referenced metadata columns from parsed SILO filter expressions. |
website/src/lapis/siloFilterExpression.spec.ts |
Adds unit tests validating metadata field extraction behavior. |
website/src/components/pageStateSelectors/BaselineSelector.tsx |
Adds AdvancedQueryFilterConfig and passes allowedFields into the advanced query UI. |
website/src/components/genspectrum/AdvancedQueryFilter.tsx |
Enforces allowedFields in the parse success path and surfaces an error when disallowed fields are used. |
website/src/components/genspectrum/AdvancedQueryFilter.browser.spec.tsx |
Adds browser specs validating the new allowedFields behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fengelniederhammer
approved these changes
May 13, 2026
Required by verbatimModuleSyntax. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…yFilter Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1bf81f3 to
142a533
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #1157, #1194
Summary
Adds an optional
allowedFieldsconfig to theadvancedQuerybaseline filter. When set, the parsed LAPIS expression is walked client-side after successful validation, and any metadata column not in the allowed list causes an error with an informative message. Mutation-only queries (e.g.A123T) always pass regardless ofallowedFields, since they reference sequence positions rather than metadata columns.AdvancedQueryFilterConfigtype exported fromBaselineSelector.tsxwith optionalallowedFields?: string[]AdvancedQueryFiltercomponent accepts and enforcesallowedFieldsin itsonSuccesshandler viaextractMetadataFieldsextractMetadataFieldsutility insiloFilterExpression.tsrecursively collects allcolumnvalues from aSiloFilterExpressiontreeThe feature is fully opt-in: omitting
allowedFieldspreserves existing behaviour (any field is allowed).Test plan
extractMetadataFieldsunit tests insiloFilterExpression.spec.tsallowedFieldsscenarios inAdvancedQueryFilter.browser.spec.tsxallowedFields: ['host']on the COVID baseline config — queries onhostpassed, queries on other metadata fields showed the error, mutation queries passedPR Checklist