New 'inline' mode in when detecting regions from filename corrected to 'snap' detections to front of priorities#253
Open
mattfeeder18 wants to merge 3 commits into
Open
New 'inline' mode in when detecting regions from filename corrected to 'snap' detections to front of priorities#253mattfeeder18 wants to merge 3 commits into
mattfeeder18 wants to merge 3 commits into
Conversation
… mode
This change would go through the regionPrios list, snap any in there that are also detected in the filename to the front, and keep them in the order they were in regionPrios. Any detected filenames that are not in regionPrios get added before the remaining regionsPrios.
Example:
If regionPrios = {"eu", "us", "jp"},
and we have "Game A (USA, Europe, Brazil)",
then this edited function would generate the 3 following lists:
detectedAndPrioritized = {"eu", "us"},
addRegionPrios = {"br"},
remainingConfigPrios = {"jp"},
and then stitch them together like this to form the order to check:
{"eu", "us", "br", "jp"}
Clarified region priority behaviour for intended 'inline' behaviour so that 'inline' and 'first' both pull detected regions to the front, but 'first' preserves the filename order and 'inline' preserves the regionPrios order.
Clarified the behaviour of region prioritisation and filename detection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New 'inline' mode in when detecting regions from filename corrected to 'snap' detections to front of priorities - old logic wasn't quite what I needed so I can made the edits necessary and adjusted the documentation to support this.
Example (for 'inline'):
If regionPrios = {"eu", "us", "jp"},
and we have "Game A (USA, Europe, Brazil)",
then this edited function would generate the 3 following lists:
detectedAndPrioritized = {"eu", "us"},
addRegionPrios = {"br"},
remainingConfigPrios = {"jp"},
and then stitch them together like this to form the order to check:
{"eu", "us", "br", "jp"}
This keeps the regionPrios in order, but shift any detections to the front and inserts detection not in regionPrios accordingly.
Again, apologies I didn't pick this up before the previous branch was committed to main.