Skip to content

docs(examples): add Hermes Tweet skill - #17

Open
kriptoburak wants to merge 2 commits into
Geeksfino:mainfrom
kriptoburak:codex/add-hermes-tweet-example-skill
Open

docs(examples): add Hermes Tweet skill#17
kriptoburak wants to merge 2 commits into
Geeksfino:mainfrom
kriptoburak:codex/add-hermes-tweet-example-skill

Conversation

@kriptoburak

@kriptoburak kriptoburak commented Jul 3, 2026

Copy link
Copy Markdown

Summary

  • Add Hermes Tweet as a real-world Claude-compatible example skill under examples/skills.
  • Demonstrate a networked skill with explicit environment requirements, read-first workflows, and gated account actions.
  • Fix scripts/test_quick.sh so Rust test failures fail the quick-test command instead of being silently ignored.

Independent Repository Fix

The quick-test script runs with set -euo pipefail, but its Rust pipeline ended with || true. That override converted every Rust test failure into success. Commit 4387d6e removes the override so the repository's primary quick check now reports real Rust failures.

Validation

  • bash -n scripts/test_quick.sh
  • cargo test --lib --test skill_session_tests: 95 unit tests and 7 integration tests passed.
  • git diff --check upstream/main
  • Confirmed OpenSkills frontmatter parsing accepts the example skill's metadata.
  • Audited the complete PR conversation, reviews, inline threads, checks, commits, and base divergence. No unresolved review request or conflict remains.

Summary by CodeRabbit

  • Documentation
    • Added a new skill guide for the Hermes Tweet toolset.
    • Included setup requirements, recommended tool flow, safety constraints, examples, testing checklist, and version history.
  • Tests / Chores
    • Updated the quick test script to no longer suppress Rust test failures, improving visibility when skill_session_tests break.

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

This PR adds a Hermes Tweet skill card covering metadata, workflows, permissions, safety, examples, testing, and release requirements, and updates the quick-test script to propagate Rust test failures.

Changes

Hermes Tweet Skill Documentation

Layer / File(s) Summary
Skill metadata and usage guidance
examples/skills/hermes-tweet/SKILL.md
Adds skill metadata, capability declarations, intended use cases, and tool-selection guidance.
Permissions, workflow, and safety rules
examples/skills/hermes-tweet/SKILL.md
Documents permission constraints, endpoint restrictions, workflow decision rules, and safety mitigations.
Outputs, pitfalls, and agent surfaces
examples/skills/hermes-tweet/SKILL.md
Defines output expectations, operational pitfalls, and Hermes Agent runtime surfaces.
Usage examples, testing, and release records
examples/skills/hermes-tweet/SKILL.md
Adds search and posting examples, validation steps, release trust requirements, and version history.

Quick Test Failure Handling

Layer / File(s) Summary
Rust quick-test failure propagation
scripts/test_quick.sh
Removes the fallback that suppressed failures from the Rust test and grep pipeline.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely matches the main change: adding the Hermes Tweet example skill under examples.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kriptoburak

Copy link
Copy Markdown
Author

Published independent repository fix in 4387d6e: scripts/test_quick.sh now propagates Rust test failures instead of swallowing them with an unconditional success override. Validation passed with 95 Rust unit tests and 7 integration tests. I also re-audited the full conversation, reviews, inline threads, checks, commits, and base divergence; no unresolved maintainer request or conflict remains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant