fix: harden frailbox logger error fallback handling - #29
Open
gelo244gum-stack wants to merge 6 commits into
Open
fix: harden frailbox logger error fallback handling#29gelo244gum-stack wants to merge 6 commits into
gelo244gum-stack wants to merge 6 commits into
Conversation
Adds explicit stderr fallback handling for log file open and write failures.
Adds make logger-error-test for the focused logger fallback harness.
Covers missing-path open fallback and /dev/full write fallback behavior.
Documents stderr fallback semantics and the logger-error-test command.
Adds diagnostic JSON metadata generated with python3 build.py.
Adds the generated diagnostic log for the logger fallback bounty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #20.
Summary
Improves the legacy frailbox logger fallback path so file-open and file-write failures preserve log output on stderr instead of silently losing messages.
Changes
LOG_FILEopens.log_dump_ring_bufferreturn-1when its descriptor write fails.frailbox/tests/test_logger_errors.ccovering missing-path open fallback and/dev/fullwrite fallback.make logger-error-testfor the focused harness.docs/OPERATIONS.md.Testing
cd frailbox && make logger-error-testgccandmakeare not available.python3 build.pydiagnostic/build-fa564fee.logd.diagnostic/build-fa564fee.json.cargo,npm,go,gcc,g++,cmake,make,javac,ruby,luac,ghc), so module builds did not complete here.Checklist