Skip to content

PHP 8.5 - Fix SoapClient doRequest #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Garethp merged 2 commits into from
Jul 21, 2026
Merged

PHP 8.5 - Fix SoapClient doRequest #288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53fafc5
Fix NTLMSoapClient doRequest for PHP 8.5
Karting06 Apr 7, 2026
0ad8a79
Enable tests on PHP 8.5
Karting06 Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/php.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ jobs:
strategy:
fail-fast: false
matrix:
php: [ '8.1', '8.2', '8.3', '8.4' ]
php: [ '8.1', '8.2', '8.3', '8.4', '8.5' ]
name: PHP ${{ matrix.php }}
steps:
- name: Checkout
Expand Down
3 changes: 2 additions & 1 deletion src/API/NTLMSoapClient.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,10 +187,11 @@ public function __construct($location, $auth, $wsdl, $options = array())
* @param string $action the soap action.
* @param integer $version the soap version
* @param integer $one_way
* @param string $uriParserClass
* @return string the xml soap response.
*/
#[\ReturnTypeWillChange]
public function __doRequest($request, $location, $action, $version, $one_way = 0)
public function __doRequest($request, $location, $action, $version, $one_way = 0, ?string $uriParserClass = null)
{
$postOptions = array(
'body' => $request,
Expand Down
Loading