Skip to content

Revert "fix(mifare): handle readable Key B fields correctly" - #977

Merged
GameTec-live merged 1 commit into
mainfrom
revert-973-fix-readable-mfc-keyb
Aug 21, 2026
Merged

Revert "fix(mifare): handle readable Key B fields correctly"#977
GameTec-live merged 1 commit into
mainfrom
revert-973-fix-readable-mfc-keyb

Conversation

@GameTec-live

Copy link
Copy Markdown
Owner

Reverts #973

Didnt test enough. My bad.

closes #976

@greptile-apps

greptile-apps Bot commented Aug 21, 2026

Copy link
Copy Markdown

Greptile Summary

This PR deliberately reverts the recently added handling and UI representation for readable MIFARE Classic Key B fields after the fix proved insufficiently tested.

  • Removes the readable Key B checkmark state, tooltip, and associated data storage.
  • Restores the previous key checking, propagation, and sector-completion behavior.
  • Updates the MIFARE Classic UI and widget test for the restored constructor contract.

Confidence Score: 5/5

The PR appears safe to merge as the reviewed changes consistently perform the explicitly requested revert without leaving broken references or incompatible persisted state.

The readable Key B state, storage, UI handling, constructor arguments, and test setup are removed consistently, and no unacknowledged actionable defect remains.

Important Files Changed

Filename Overview
chameleonultragui/lib/helpers/mifare_classic/recovery.dart Restores the previous MIFARE Classic key-recovery behavior by removing readable Key B classification and memory-access verification.
chameleonultragui/lib/gui/component/key_check_marks.dart Removes the readable-data input and blue visibility indicator associated with readable Key B fields.
chameleonultragui/lib/gui/component/mifare/classic.dart Updates the sole production KeyCheckMarks call site to match the reverted widget API.
chameleonultragui/test/key_check_marks_test.dart Updates the widget test setup to match the reverted KeyCheckMarks constructor.

Reviews (1): Last reviewed commit: "Revert "fix(mifare): handle readable Key..." | Re-trigger Greptile

@GameTec-live
GameTec-live merged commit fb9178f into main Aug 21, 2026
21 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in Chameleon Ultra GUI Aug 21, 2026
@GameTec-live
GameTec-live deleted the revert-973-fix-readable-mfc-keyb branch August 21, 2026 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Inability to record a card

1 participant