Revert "fix(mifare): handle readable Key B fields correctly" - #977
Merged
Conversation
This reverts commit 04be0ad.
Greptile SummaryThis PR deliberately reverts the recently added handling and UI representation for readable MIFARE Classic Key B fields after the fix proved insufficiently tested.
Confidence Score: 5/5The PR appears safe to merge as the reviewed changes consistently perform the explicitly requested revert without leaving broken references or incompatible persisted state. The readable Key B state, storage, UI handling, constructor arguments, and test setup are removed consistently, and no unacknowledged actionable defect remains.
|
| Filename | Overview |
|---|---|
| chameleonultragui/lib/helpers/mifare_classic/recovery.dart | Restores the previous MIFARE Classic key-recovery behavior by removing readable Key B classification and memory-access verification. |
| chameleonultragui/lib/gui/component/key_check_marks.dart | Removes the readable-data input and blue visibility indicator associated with readable Key B fields. |
| chameleonultragui/lib/gui/component/mifare/classic.dart | Updates the sole production KeyCheckMarks call site to match the reverted widget API. |
| chameleonultragui/test/key_check_marks_test.dart | Updates the widget test setup to match the reverted KeyCheckMarks constructor. |
Reviews (1): Last reviewed commit: "Revert "fix(mifare): handle readable Key..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #973
Didnt test enough. My bad.
closes #976