Added new features. - #8
Open
idkcode22 wants to merge 13 commits into
Open
Conversation
To allow Beat Saber 1.39.1 to work
Updated logging messages for clarity and improved comments.
Added new configuration options for hitsound behavior.
Added logic to detect spatializer plugin and choose appropriate settings menu resource.
Owner
|
Apologies for the wait, I'll try to get to this soon |
Author
|
It’s no worries take your time. I accidentally deleted the branch while trying to create a new one.😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first time contributing to any sort of open source project, so I apologize in advance if I make any mistakes.
All of these added features may not be necessary or useful, but I've added them because they are features I would like to see in hitsoundtweaks. With that said, feel free to add some of these features or close this PR if you don't find these features useful.
Features that I've added within the fork.
Added a spatializer detector, so if the mod is installed on a Beat Saber version that doesn't contain an audio spatializer, it creates a message within the logs saying that their version of Beat Saber doesn't have a spatializer and to downgrade below 1.40.2 for spatialized hitsounds. I've also added it so that if a spatializer isn't present, the hover hint of the hitsound spatialization settings option explains that the hitsounds won't be spatialized and will be stereo-panned instead due to Unity's way of handling spatial audio without an audio spatializer.
Added an option where if the player doesn't cut a note, the hitsound will be paused at the point considered hit on hitsound scheduling, effectively making it so the player won't hear hitsounds unless they cut a note.
Also added an option to have it where the hitsound will follow the saber after its cut, giving a sort of resonance to the saber.