docs: encode the Copilot-first PR babysit loop in pr_review_iteration#3240
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the skills/pr_review_iteration.md skill documentation to formalize a “Copilot-first” PR iteration loop (fast re-review cycles) and to route post-Copilot CI failures back through that same loop.
Changes:
- Rewrites Section 1 to prescribe a push → re-request Copilot → act → repeat loop until Copilot is “dry”, then wait for CI.
- Adds explicit guidance on handling CI failures both during and after the Copilot loop, including returning to Copilot after CI-fix commits.
- Expands operational guidance (polling cadence, status commands, and a “pure-prose tail” warning).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
borisbat
force-pushed
the
bbatkin/babysit-loop-skill
branch
from
ce552e0 to
25f1fcf
Compare
borisbat
force-pushed
the
bbatkin/babysit-loop-skill
branch
from
25f1fcf to
8f6b823
Compare
Rewrite pr_review_iteration.md Section 1 around the loop we converged on while shipping the nightly-CI (#3237) and lint (#3239) PRs: iterate against Copilot (~5 min, free ruleset check), never block on the ~30-min CI matrix between rounds; only wait for green once Copilot is dry. A red EARLY during the loop is a free signal (jump on it); a red AFTER Copilot is dry loops back into Copilot (the fix is new code). Manual re-request is mandatory - review_on_push does not auto-fire on any push. Section 3: make the comment-triage bar conservative - default reject, accept only real bugs, real issues, or factually-incorrect text. Reject prose/wording nits (unless way off or factually wrong), unlikely/never- happen bugs, over-defensive guards, and suggestions that diverge from repo convention. Replaces the old "cosmetic accept" table row. Prose-tail note, quick-ref triage row, and Section 2's CI-fix step aligned to match. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
borisbat
force-pushed
the
bbatkin/babysit-loop-skill
branch
from
8f6b823 to
6d96155
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Captures the PR-babysitting loop and the conservative comment-triage bar we converged on while shipping the nightly-CI (#3237) and lint (#3239) PRs, in
skills/pr_review_iteration.md.The loop (Section 1, rewritten)
review_on_pushdid NOT auto-fire on any push (force or normal) in testing; Copilot only auto-reviews once, on PR open.Conservative triage (Section 3, rewritten)
Section 2's CI-fix step and the quick-ref triage row aligned to match. Force-push/squash mechanics (Sections 5–7) unchanged — that's the separate, still-open no-force-push question.
Docs-only.
🤖 Generated with Claude Code