Fix mayDrinkWhenFull tfc - #44
Open
Ujhik wants to merge 2 commits into
Open
Conversation
…kable inside has mayDrinkWhenFull to true in tfc
Owner
|
If it's not already, let's set the TFC version to the earliest 1.20 where that option appears, rather than the (almost) newest. |
Author
The option appears first in tfc "3.1.4-beta", the first non-beta version after that is "3.1.6", so if you agree I can put the 3.1.6 to avoid beta versions just in case |
Owner
|
That sounds good.
…On Sat, Jun 27, 2026, 03:20 Ujhik ***@***.***> wrote:
*Ujhik* left a comment (Gaelmare/WaterFlasks#44)
<#44 (comment)>
If it's not already, let's set the TFC version to the earliest 1.20 where
that option appears, rather than the (almost) newest.
The option appears first in tfc "3.1.4-beta", the first non-beta version
after that is "3.1.6", so if you agree I can put the 3.1.6 to avoid beta
versions just in case
—
Reply to this email directly, view it on GitHub
<#44?email_source=notifications&email_token=AN3ODQLFLPXHTP56LIHPRFT5B6GWLA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOBRGYZTKNJXGY22M4TFMFZW63VHMNXW23LFNZ2KKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-4816355765>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AN3ODQNAHGOMFCSF7QEGH7T5B6GWLAVCNFSNUABFKJSXA33TNF2G64TZHMZDENRWGI3TAOBQHNEXG43VMU5TINZTHAYDIMJSGIZKC5QC>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/AN3ODQPOAUWUKQIJZ3IERHD5B6GWLA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOBRGYZTKNJXGY22M4TFMFZW63VHMNXW23LFNZ2KKZLWMVXHJKTGN5XXIZLSL5UW64Y>
and Android
<https://github.com/notifications/mobile/android/AN3ODQJWQ4JOX2SEWRT27XT5B6GWLA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOBRGYZTKNJXGY22M4TFMFZW63VHMNXW23LFNZ2KKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
Download it today!
You are receiving this because you commented.Message ID:
***@***.***>
|
…enFull is available in Drinkable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #41