Skip to content

feat!(appeng): add table/NBT support and add backward compatibility#194

Merged
Dream-Master merged 12 commits into
GTNewHorizons:masterfrom
hinyb:feat
Jun 15, 2026
Merged

feat!(appeng): add table/NBT support and add backward compatibility#194
Dream-Master merged 12 commits into
GTNewHorizons:masterfrom
hinyb:feat

Conversation

@hinyb

@hinyb hinyb commented May 16, 2026

Copy link
Copy Markdown

Features:

  • add getCraftable
  • add table support for get*InNetwork for consistany
  • add nbt support for item and add some functions for DataCard to modify nbt.
  • introduced nbt.lua as a helper library, it is used to auto-handle the new NBT struct, allowing users to read/write existing values naturally.

BREAKING:

  • changed decodeNBT output struct to persist type information, ensuring it can be re-encoded properly. Users can use the new nbt.lua to access values as before.

Compatibility:

@hinyb hinyb changed the title feat(appeng): add table support for get*InNetwork apis and nbt support for item feat(appeng): add table support for apis and nbt support for item May 20, 2026
@hinyb hinyb changed the title feat(appeng): add table support for apis and nbt support for item feat!(appeng): add table/NBT support and add backward compatibility May 25, 2026
@boubou19 boubou19 requested a review from a team May 30, 2026 19:55

@Guvante Guvante left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing major but haven't quite groked how the metatable interacts with the types to approve but that might just be because it is late

Comment thread src/main/scala/li/cil/oc/integration/appeng/NetworkControl.scala
Comment thread src/main/scala/li/cil/oc/integration/vanilla/ConverterNBT.scala Outdated
@Dream-Master Dream-Master requested a review from Guvante June 14, 2026 09:25

@Guvante Guvante left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't dabbled in Lua metatable recently enough to be totally certain of how effective this setup is but nothing pops out as obviously wrong

Comment thread src/main/resources/assets/opencomputers/loot/openos/lib/nbt.lua
Comment thread src/main/scala/li/cil/oc/server/component/DataCard.scala
@Dream-Master Dream-Master merged commit c00f0bd into GTNewHorizons:master Jun 15, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow OpenComputers to set/adjust patterns directly with ID and damage values. getFluidsInNetwork() now caps fluids at MAXINT, Change to Float?

3 participants