Skip to content

Fix RPSL explorer compilation not working on Windows - #29

Open
Mcgode wants to merge 2 commits into
GPUOpen-LibrariesAndSDKs:mainfrom
Mcgode:main
Open

Fix RPSL explorer compilation not working on Windows#29
Mcgode wants to merge 2 commits into
GPUOpen-LibrariesAndSDKs:mainfrom
Mcgode:main

Conversation

@Mcgode

@Mcgode Mcgode commented May 6, 2023

Copy link
Copy Markdown

The RPSL compilation command does not work on Windows, and seems to have been designed for Unix-like systems.

This PR fixes the command line for Windows, while keeping compatibility with Unix systems.
Addresses #28

@expenses

expenses commented May 8, 2023

Copy link
Copy Markdown

I think using the std::filesystem:path functions would be tidier: https://en.cppreference.com/w/cpp/filesystem/path/make_preferred. But I'm not sure what version of c++ RPS is targetting.

@Mcgode

Mcgode commented May 9, 2023

Copy link
Copy Markdown
Author

Indeed, thanks for the comment.

The RPS lib itself target C++11 but rpsl_explorer.hpp itself uses C++17 (and already uses std::filesystem::path in the same function)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants