feat(settings): option to skip automatic session reconnect at startup… - #127
Open
twkrol wants to merge 1 commit into
Open
feat(settings): option to skip automatic session reconnect at startup…#127twkrol wants to merge 1 commit into
twkrol wants to merge 1 commit into
Conversation
…GOODBOY008#126) Add a "Reconnect Sessions on Startup" switch (Settings > Connection, default on). When it is off, the tabs left open in the previous session are still restored to the layout, but App.tsx starts no backend connection for them: they stay `pending` and show an explicit Connect button (the tab context menu Reconnect works too). An info toast tells the user how many tabs were left disconnected. The active-connections list is kept so the tabs persist again for the next launch. - src/lib/startup-restore.ts: read the preference from the persisted app settings; only an explicit `false` disables the restore so existing installs keep the current behaviour. - App.tsx: early return in the restore effect; track deferred tab ids and drop them when the user reconnects a tab. - terminal-tab-portals.tsx: Connect action in the pending placeholder for deferred tabs; the pulsing "Waiting for connection..." stays for in-flight connects. - Settings modal + en/zh-CN strings (i18n parity checked). - Tests: helper unit tests and an App-level test covering default restore, skipped restore, and connect-on-demand. Closes GOODBOY008#126 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… (#126)
Add a "Reconnect Sessions on Startup" switch (Settings > Connection, default on). When it is off, the tabs left open in the previous session are still restored to the layout, but App.tsx starts no backend connection for them: they stay
pendingand show an explicit Connect button (the tab context menu Reconnect works too). An info toast tells the user how many tabs were left disconnected. The active-connections list is kept so the tabs persist again for the next launch.falsedisables the restore so existing installs keep the current behaviour.Closes #126