Fix dest→source multithread chunk sizing and add single-vs-multithread parity coverage#4
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix multithread bug for destination to source mode
Fix dest→source multithread chunk sizing in interpolation
Jun 9, 2026
dodu94
requested changes
Jun 9, 2026
dodu94
left a comment
Member
There was a problem hiding this comment.
seems ok, please add a test where it is demonstrated that multithread and single core interpolations yield exactly the same result
Copilot
AI
changed the title
Fix dest→source multithread chunk sizing in interpolation
Fix dest→source multithread chunk sizing and add single-vs-multithread parity coverage
Jun 9, 2026
dodu94
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Destination→source interpolation could fail in multithread mode when worker count exceeded destination points, due to mismatched partial block shapes during assembly. This update scopes block outputs to the active slice and adds explicit parity coverage to ensure multithread and single-core paths produce identical results.
Root cause
interpolate_block(dest→source mode), the block output buffer was allocated using full destination length instead of the current chunk length.Code change
Regression coverage
interpolated,unmapped) are exactly equal betweenmultithread=Falseandmultithread=Truefor the same input.