[CRASHFIX] Fix Chart Editor crashing when character pixel icon is missing - #8087
Open
kiryvajiravuth wants to merge 1 commit into
Open
[CRASHFIX] Fix Chart Editor crashing when character pixel icon is missing#8087kiryvajiravuth wants to merge 1 commit into
kiryvajiravuth wants to merge 1 commit into
Conversation
github-actions
Bot
added
status: pending triage
NotHyper-474
added
type: major bug
Contributor
Author
|
My BUM ahh forgot to mute my mic :nails: |
Contributor
What? |
Contributor
Author
I could hear background noices in the recording |
4 tasks
…a trace cuz why not)
kiryvajiravuth
force-pushed
the
fix-icon-crash
branch
from
September 7, 2026 13:38
93cac41 to
75a1297
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issues
Closes #6739
Description
The Chart Editor Metadata Toolbox and Character Icon Selector crash with
Null Object Referencewhen a character's pixel icon asset (e.g.ui/freeplay/characters/darnell.pngorui/freeplay/characters/darnell.xml) is missing or corrupted.Two fixes applied:
CharacterData.hx:getCharPixelIconAsset()now catches asset load failures in a try/catch and returnsnullinstead of crashing.ChartEditorMetadataToolbox.hxandChartEditorCharacterIconSelectorMenu.hx: All callers ofgetCharPixelIconAsset()now nullcheck the result before passing it toVariant.fromImageData().When a pixel icon is missing, the button shows no icon instead of crashing.
Screenshots/Videos
Before :
before.mp4
After :
after.mp4