Skip to content

[BUGFIX] Fix hold note score being inconsistent on different FPS - #8080

Open
iLauncherDev wants to merge 1 commit into
FunkinCrew:preview/public-playtestfrom
iLauncherDev:fix_FNF_hold_score
Open

[BUGFIX] Fix hold note score being inconsistent on different FPS#8080
iLauncherDev wants to merge 1 commit into
FunkinCrew:preview/public-playtestfrom
iLauncherDev:fix_FNF_hold_score

Conversation

@iLauncherDev

@iLauncherDev iLauncherDev commented Sep 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Linked Issues

Description

Fix hold note score being inconsistent on different FPS by limiting elapsed to holdNote.sustainLength

Screenshots/Videos

@github-actions github-actions Bot added status: pending triage Awaiting review. size: small A small pull request with 10 or fewer changes. pr: haxe PR modifies game code. labels Sep 4, 2026
@NotHyper-474 NotHyper-474 added type: minor bug Involves a minor bug or issue. topic: scoring Involves the game's ranking and scoring systems. status: needs revision Cannot be approved because it is awaiting some work by the contributor. and removed status: pending triage Awaiting review. labels Sep 4, 2026
@iLauncherDev
iLauncherDev marked this pull request as ready for review September 4, 2026 17:31
@Hundrec Hundrec added status: pending triage Awaiting review. and removed status: needs revision Cannot be approved because it is awaiting some work by the contributor. labels Sep 6, 2026
@Hundrec Hundrec linked an issue Sep 6, 2026 that may be closed by this pull request
Bug Report: Inconsistent Sustain Scoring between FPS #4512
Open
3 tasks
@Hundrec
Hundrec requested a review from Kade-github September 6, 2026 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kade-github Kade-github Awaiting requested review from Kade-github

Assignees

No one assigned

Labels

pr: haxe PR modifies game code. size: small A small pull request with 10 or fewer changes. status: pending triage Awaiting review. topic: scoring Involves the game's ranking and scoring systems. type: minor bug Involves a minor bug or issue.

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug Report: Inconsistent Sustain Scoring between FPS

3 participants

@iLauncherDev @NotHyper-474 @Hundrec