[BUGFIX] Invert input offset values - #8072
Open
zxcksharks wants to merge 2 commits into
Open
Conversation
that should fix it
github-actions
Bot
added
status: pending triage
github-actions
Bot
added
pr: haxe
NotHyper-474
added
type: minor bug
4 tasks
iLauncherDev
reviewed
Sep 2, 2026
| @@ -627,7 +627,7 @@ class OffsetMenu extends Page<OptionsState.OptionsMenuPageName> | |||
| var arrow:ArrowData = getClosestArrowAtBeat(b); | |||
Contributor
There was a problem hiding this comment.
i don't think you should be changing this file
Contributor
Author
There was a problem hiding this comment.
Why not...?
Not changing this file means that calibration will give the wrong direction of offsets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Does not handle save migration i.e. flipping the offset for existing players. Players will need to re-calibrate if this is pulled without further changes.
(I wanted to try doing this initially, but there doesn't seem to be any existing functions for migrating save data...?)
Linked Issues
#7711
(Reopen of #7990 due to git issues)
Description
Offsets used to be inverted. Now they aren't. Cool?
Screenshots/Videos
N/A (Self-explanatory, lazy)