[ENHANCEMENT/BUGFIX] Rewrite wiggle shader.

[ThatRozebudDude]

Rewrites the wiggle shader to be less confusing and fixes issue #7976 where the wiggle shader doesn't render correctly on certain GPUs due to precision issues. Also adds the ability to enable or disable pixel snapping across the whole shader instead of it being automatically disabled only on the dreamy effect.

Requires FunkinCrew/funkin.assets#468 to also be merged.

Here are 2 videos MistrDJ recorded for me since my GPU doesn't have the issue. The first is how the shader currently looks and the second is how it looks with this fix.

dj_shader_broken.mp4

dj_shader_fix.mp4

This shouldn't change how the shader looks at all in the context of how it is used in Week 6 as long as you didn't have the shader issue.

[AppleHair]

#2329 tried to do this a long time ago and got rejected:

"Phantom Arcade prefers the Before style as it is more authentic to the visuals from the graphical style being referenced. Thus, this change is rejected." - Eric

[FuroYT]

#2329 tried to do this a long time ago and got rejected:

"Phantom Arcade prefers the Before style as it is more authentic to the visuals from the graphical style being referenced. Thus, this change is rejected." - Eric

Rozebud said “This shouldn't change how the shader looks at all in the context of how it is used in Week 6” so this isn’t a visual change but rather a bug fix for AMD Graphics since shaders are not rendered the same way that Nvidia or Intel does.

[AppleHair]

Rozebud said “This shouldn't change how the shader looks at all in the context of how it is used in Week 6” so this isn’t a visual change but rather a bug fix for AMD Graphics since shaders are not rendered the same way that Nvidia or Intel does.

I'm not really sure what he ment by that, because if you look at the footage he provided you can clearly see a visual change that matches exactly to the older PR that was rejected.

If you ask me I don't really mind the change, but I'm just saying that a PR with a similar change was rejected in the past. Just as a heads-up.

[ThatRozebudDude]

Considering that the way the shader looks with the bug only happens on certain hardware and the old version of the background with the effect baked as a sprite sheet I doubt that it was the intended look of the stage. Whether he actually preferred the look of the bugged version I don't know but either way that isn't how it looks on the majority of devices so either the bug should be fixed or the shader should be adjusted to make the bugged version consistent on all machines. Again based on how the shader was written and how the old version of the stage looked I believe the fixed version is the original intended look anyways.

[AppleHair]

Considering that the way the shader looks with the bug only happens on certain hardware and the old version of the background with the effect baked as a sprite sheet I doubt that it was the intended look of the stage. Whether he actually preferred the look of the bugged version I don't know but either way that isn't how it looks on the majority of devices so either the bug should be fixed or the shader should be adjusted to make the bugged version consistent on all machines. Again based on how the shader was written and how the old version of the stage looked I believe the fixed version is the original intended look anyways.

Absolutely agree with that, but again, because Phantom Arcade evidently prefers the bugged look, I think it's very possible that the devs would want to make the bugged look consistent on all machines, despite it not being the original look.

It's just my observation though. I don't actually know what they would want to do with this PR.

[Hundrec]

Thanks for the discussion, we'll be sure to present this to Dave at some point to see which he prefers now