[OPTIMIZATION] Set active to false on SustainTrails - #8049
Open
ADA-Funni wants to merge 2 commits into
Open
Conversation
github-actions
Bot
added
status: pending triage
Hundrec
force-pushed
the
preview/public-playtest
branch
from
August 30, 2026 11:12
ae0e3ff to
b190bf7
Compare
Hundrec
added
the
type: optimization
Hundrec
changed the title
active to false on SustainTrails.active to false on SustainTrails
nykwono
suggested changes
Aug 30, 2026
nykwono
left a comment
nykwono
left a comment
Contributor
There was a problem hiding this comment.
You should make Strumline.scrollSpeed a setter function that updates the holds so the hold notes their update size because with SustainTrail.active being false will make them be off until you hit them.
Contributor
Author
That should be a separate pull request |
ADA-Funni
force-pushed
the
adafunni/sustaintrail-active
branch
from
August 31, 2026 00:23
1d75789 to
bd38bae
Compare
github-actions
Bot
added
size: medium
Hundrec
force-pushed
the
preview/public-playtest
branch
from
September 1, 2026 15:49
3f2fe37 to
a1fa227
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the same optimisation used by
NoteSpritewhen the graphic isn't animated to prevent FPS drops.SustainTrails are obviously not animated, so this fix seems like a no-brainer to me.