[ENHANCEMENT] Cut note snap value in half when holding Control - #7950
Open
ADA-Funni wants to merge 2 commits into
Open
[ENHANCEMENT] Cut note snap value in half when holding Control#7950ADA-Funni wants to merge 2 commits into
ADA-Funni wants to merge 2 commits into
Conversation
github-actions
Bot
added
status: pending triage
Hundrec
added
type: enhancement
ADA-Funni
force-pushed
the
adafunni/control-note-snap
branch
from
August 18, 2026 22:58
ec4dae2 to
5a9f721
Compare
EliteMasterEric
requested changes
Aug 19, 2026
| function get_noteSnapQuant():Int | ||
| { | ||
| return SNAP_QUANTS[noteSnapQuantIndex]; | ||
| return Std.int(SNAP_QUANTS[noteSnapQuantIndex] * (pressingControl() ? 2 : 1)); |
Member
There was a problem hiding this comment.
I think the logic for this should probably be reworked, since currently you can get values that aren't in the SNAP_QUANTS array.
Contributor
Author
There was a problem hiding this comment.
Ah, I anticipated that, but assumed it wasn't an issue.
I'll do something about that tomorrow
Contributor
Author
There was a problem hiding this comment.
Got caught up in school stuff, but I'm able to work on it now.
Is this good?
function get_noteSnapQuant():Int
{
if (pressingControl()) {
final result:Int = Std.int(SNAP_QUANTS[noteSnapQuantIndex] * 2);
if (SNAP_QUANTS.contains(result)) return result;
}
return SNAP_QUANTS[noteSnapQuantIndex];
}
AbnormalPoof
force-pushed
the
preview/public-playtest
branch
from
August 20, 2026 03:25
401b06b to
2e7f104
Compare
Hundrec
added
status: needs revision
Hundrec
changed the title
Hundrec
force-pushed
the
preview/public-playtest
branch
from
August 21, 2026 09:53
fff3525 to
25ad66b
Compare
ADA-Funni
force-pushed
the
adafunni/control-note-snap
branch
from
August 21, 2026 13:03
5a9f721 to
25ad66b
Compare
github-actions
Bot
added
size: tiny
…owing the charter to place notes more precisely.
github-actions
Bot
added
size: large
Contributor
Author
|
Had to do some horrible dark magic to rebase this PR, and apparently Git closed the fucker for me when I didn't want it closed, but my branch works now. |
…o Control + Alt + Click.
Hundrec
added
status: pending triage
Hundrec
force-pushed
the
preview/public-playtest
branch
from
September 1, 2026 15:49
3f2fe37 to
a1fa227
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For example, if I'm on 1/16 and hold Control, the note snap becomes 1/32.