Skip to content

[ENHANCEMENT] Add Zoom to Camera SongEvent / Lerped camera Zoom / Little touches on stuff - #5086

Closed
PurSnake wants to merge 5 commits into
FunkinCrew:developfrom
PurSnake:camera_zoom-rewrite
Closed

[ENHANCEMENT] Add Zoom to Camera SongEvent / Lerped camera Zoom / Little touches on stuff#5086
PurSnake wants to merge 5 commits into
FunkinCrew:developfrom
PurSnake:camera_zoom-rewrite

Conversation

@PurSnake

@PurSnake PurSnake commented May 14, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

This pr adds:

  • More ease's for Zoom Camera SongEvent.
  • A little rewrite how camera zooming handled in PlayState, now camera's zoom changes regardless of fps.
  • Added cameraZoomingDecay for camera's zooming speed.
  • Added DEFAULT_HUD_BOP_INTENSITY field in Constants, because YES.
  • Added ability to do LERPED zoom for camGame.
    And etc.
8mb.video-76U-NzLoLd67.mp4

blowme

@github-actions github-actions Bot added status: pending triage Awaiting review. size: large A large pull request with more than 100 changes. pr: haxe PR modifies game code. and removed size: large A large pull request with more than 100 changes. labels May 14, 2025
@Hundrec Hundrec added size: large A large pull request with more than 100 changes. type: enhancement Involves an enhancement or new feature. labels May 14, 2025
@MAZ12211

MAZ12211 commented May 14, 2025

Copy link
Copy Markdown

This is cool
Having a showcase of the event would benefit this pr though

@EliteMasterEric EliteMasterEric added size: large A large pull request with more than 100 changes. and removed size: large A large pull request with more than 100 changes. labels May 14, 2025
@PurSnake

PurSnake commented May 14, 2025

Copy link
Copy Markdown
Contributor Author

Added video showcase

@AbnormalPoof

AbnormalPoof commented May 14, 2025

Copy link
Copy Markdown
Member

Doesn't the Zoom Camera song event already do this?

@AbnormalPoof AbnormalPoof added status: needs clarification Requires more info from the author. and removed status: pending triage Awaiting review. labels May 14, 2025
@Hundrec Hundrec added the topic: chart editor Related to the operation of the Chart Editor. label May 14, 2025
@PurSnake

PurSnake commented May 14, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Doesn't the Zoom Camera song event already do this?

Add Zoom to Camera Event ADDS to already setted zoom value for game/hud camera (then added value will go away with zoom lerp)
While Zoom Camera Event SETS new zoom value for gameplay camera

@PurSnake

PurSnake commented May 14, 2025

Copy link
Copy Markdown
Contributor Author

Well, if you're talking about lepred zoom, then I added it because I know many situations where it's better (more beautiful/fits better) and easier to do a lerp of the camera zoom, rather than tween

@AbnormalPoof AbnormalPoof added status: pending triage Awaiting review. and removed status: needs clarification Requires more info from the author. labels May 14, 2025
@Redar13
Redar13 deleted the camera_zoom-rewrite branch January 27, 2026 13:10
@Hundrec

Hundrec commented Aug 29, 2026

Copy link
Copy Markdown
Member

Would you like to bring this change to preview/public-playtest?

@Hundrec Hundrec added status: needs revision Cannot be approved because it is awaiting some work by the contributor. and removed status: pending triage Awaiting review. labels Aug 29, 2026
@PurSnake

PurSnake commented Aug 29, 2026

Copy link
Copy Markdown
Contributor Author

Sure thing

@PurSnake PurSnake mentioned this pull request Sep 3, 2026
Open
@PurSnake

PurSnake commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

#8075

@PurSnake PurSnake closed this Sep 3, 2026
@NotHyper-474 NotHyper-474 added status: duplicate Issue or PR is redundant to another. and removed type: enhancement Involves an enhancement or new feature. topic: chart editor Related to the operation of the Chart Editor. status: needs revision Cannot be approved because it is awaiting some work by the contributor. pr: haxe PR modifies game code. labels Sep 3, 2026
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

This pull request is a duplicate. Please direct all discussion to the original pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size: large A large pull request with more than 100 changes. status: duplicate Issue or PR is redundant to another.

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@PurSnake @MAZ12211 @AbnormalPoof @Hundrec @EliteMasterEric @NotHyper-474