Skip to content

[CHART EDITOR] Added tooltip field for data event fields - #4220

Closed
amyspark-ng wants to merge 3 commits into
FunkinCrew:developfrom
amyspark-ng:add-event-field-tooltips
Closed

[CHART EDITOR] Added tooltip field for data event fields#4220
amyspark-ng wants to merge 3 commits into
FunkinCrew:developfrom
amyspark-ng:add-event-field-tooltips

Conversation

@amyspark-ng

@amyspark-ng amyspark-ng commented Feb 24, 2025

Copy link
Copy Markdown
Contributor

Does this PR close any issues? If so, link them below.

fixes #4218

Briefly describe the issue(s) fixed.

This adds tooltips for event data fields, this way the field of any event toolbox will add extra info on how the event uses that field

Mods that use custom events can also make use of this when creating their SongEventSchema, it would look something like this:

class CustomEvent extends SongEvent {
    public function new() {
        super('customEvent');
    }
    
    public override function getEventSchema(): SongEventSchema {
        return [
            {
                name: "quantity",
                title: "Attack Quantity",
                defaultValue: 1,
                type: "integer",
                step: 1,
                tooltip: 'The amount of attacks to do.'
            }
        ];
    }
}

Include any relevant screenshots or videos.

You can't look at it properly due to #4126 but they seem to work properly

2025-02-23_22-27-30.mp4

@github-actions github-actions Bot added pr: haxe PR modifies game code. status: pending triage Awaiting review. size: medium A medium pull request with 100 or fewer changes. labels Feb 24, 2025
@AbnormalPoof AbnormalPoof added type: enhancement Involves an enhancement or new feature. topic: chart editor Related to the operation of the Chart Editor. labels Feb 24, 2025
@Hundrec Hundrec added status: needs revision Cannot be approved because it is awaiting some work by the contributor. and removed status: pending triage Awaiting review. labels Apr 5, 2025
@Hundrec

Hundrec commented Apr 5, 2025

Copy link
Copy Markdown
Member

Merge conflicts? We got em

@amyspark-ng

Copy link
Copy Markdown
Contributor Author

how do i fix do i just merge develop to this?

@Hundrec

Hundrec commented Apr 5, 2025

Copy link
Copy Markdown
Member

Very good

@Hundrec Hundrec added status: pending triage Awaiting review. and removed status: needs revision Cannot be approved because it is awaiting some work by the contributor. labels Apr 5, 2025
@AbnormalPoof
AbnormalPoof self-requested a review April 23, 2025 00:58
@EliteMasterEric EliteMasterEric added size: medium A medium pull request with 100 or fewer changes. and removed size: medium A medium pull request with 100 or fewer changes. labels May 14, 2025
@amyspark-ng

Copy link
Copy Markdown
Contributor Author

added size medium and removed size medium...

@Hundrec

Hundrec commented May 15, 2025

Copy link
Copy Markdown
Member

True...

@Hundrec Hundrec linked an issue Jun 30, 2025 that may be closed by this pull request
3 tasks
@amyspark-ng

Copy link
Copy Markdown
Contributor Author

how do i update this to master again? i think this is my only open pr that would be worth merging i think XD

@MAZ12211

Copy link
Copy Markdown

Bumping this since it's starting to get necessary with custom events with properties that need explanation

@amyspark-ng

Copy link
Copy Markdown
Contributor Author

i should maybe just re do this PR entirely

@EliteMasterEric EliteMasterEric self-assigned this Dec 2, 2025
@Hundrec
Hundrec force-pushed the develop branch 2 times, most recently from 3829dcb to 5805c31 Compare February 1, 2026 03:24
@EliteMasterEric
EliteMasterEric self-requested a review March 7, 2026 14:41
@EliteMasterEric EliteMasterEric removed their assignment Mar 7, 2026

@EliteMasterEric EliteMasterEric left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was going to review this but it's littered with conflicts, please rebase and squash thanks

@Hundrec Hundrec added status: needs revision Cannot be approved because it is awaiting some work by the contributor. and removed status: pending triage Awaiting review. labels Mar 9, 2026
@amyspark-ng

amyspark-ng commented Mar 19, 2026

Copy link
Copy Markdown
Contributor Author

chart editor crashes on develop why?

image

@NotHyper-474

Copy link
Copy Markdown
Collaborator

You likely didn't update assets.

@NotHyper-474

Copy link
Copy Markdown
Collaborator

Reminder to fix the merge conflicts. You may create a separate PR if that's easier for you.

@amyspark-ng

Copy link
Copy Markdown
Contributor Author

will get back to this in a bit

@amyspark-ng

Copy link
Copy Markdown
Contributor Author

closed in favor of #7963

@Hundrec
Hundrec removed the request for review from AbnormalPoof August 19, 2026 04:45
@Hundrec Hundrec added status: duplicate Issue or PR is redundant to another. and removed type: enhancement Involves an enhancement or new feature. topic: chart editor Related to the operation of the Chart Editor. status: needs revision Cannot be approved because it is awaiting some work by the contributor. pr: haxe PR modifies game code. labels Aug 19, 2026
@github-actions

Copy link
Copy Markdown

This pull request is a duplicate. Please direct all discussion to the original pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: medium A medium pull request with 100 or fewer changes. status: duplicate Issue or PR is redundant to another.

Development

Successfully merging this pull request may close these issues.

Enhancement: Tooltips for event values

6 participants