new sliding window by time function#374
Conversation
|
Dont forget to add tests :D https://github.com/FundingCircle/jackdaw/blob/master/test/jackdaw/streams_test.clj |
|
@kidpollo I have (finally) added the test. Also looked at my implementation and made some modifications. Let me know what you think |
|
It doesn't pass the tests. We are getting intermediate values from the windows. Will try suppressing those until the windows close |
|
@kidpollo This is done, tests are now passing. |
@kidpollo Great, thanks! Hope it will get merged too! |
|
Any updates here? @kidpollo |
|
Unfortunately I am no longer an FC employee and have no insight on who actually runs this project :P maybe @jbropho ? |
|
@jbropho Can you review the PR? |
|
@kidpollo Anyone else you can think of for reviewing the PR? |
|
Unfortunately no. If you are super eager you could go down the list of contributor, however most dont work for FC. I feel that if this project has enough other users it should be given back to the community. Easy said ... |
|
Just checking again, is this PR going to be reviewed/merged? @marcoccchan @AndrewKeedle @kidpollo @jbropho |
2 participants
Implemented sliding window functionality