Skip to content

Check types against the interface #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dfbernal wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Check types against the interface #310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
01c6dcb
allow use of implementing interfaces in partitions-for function
dfbernal Dec 10, 2020
5304f9e
Merge branch 'FundingCircle:master' into master
dfbernal Nov 24, 2021
7d387e0
Update CHANGELOG.md
dfbernal Nov 24, 2021
65f6e7e
Merge branch 'master' into master
dfbernal Nov 24, 2021
56bd992
Update CHANGELOG.md
dfbernal Nov 24, 2021
aebfecf
Merge branch 'master' of github.com:FundingCircle/jackdaw into Fundin…
dfbernal Jun 1, 2022
0a1ce3a
Merge branch 'FundingCircle-master'
dfbernal Jun 1, 2022
7089836
updating CHANGELOG
dfbernal Jun 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

### [0.9.6] - [2022-06-01]

* Fixed Type checking against concrete class instead of interface

### [0.9.5] - [2022-05-26]

* Move away from deprecated class ConsumerRecordFactory (to prepare migration to Kafka Streams 3.2.0)
Expand Down
8 changes: 4 additions & 4 deletions src/jackdaw/client.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,11 +155,11 @@
metadata about the partitions assigned to the given consumer or
producer."
[producer-or-consumer {:keys [^String topic-name]}]
(->> (cond (instance? KafkaConsumer producer-or-consumer)
(.partitionsFor ^KafkaConsumer producer-or-consumer topic-name)
(->> (cond (instance? Consumer producer-or-consumer)
(.partitionsFor ^Consumer producer-or-consumer topic-name)

(instance? KafkaProducer producer-or-consumer)
(.partitionsFor ^KafkaProducer producer-or-consumer topic-name)
(instance? Producer producer-or-consumer)
(.partitionsFor ^Producer producer-or-consumer topic-name)

:else (throw (ex-info "Got non producer/consumer!"
{:inst producer-or-consumer
Expand Down