Decoupled topology#278
Conversation
* Renamed test ns to correct file path * Modified jackdaw.streams/kafka-streams to accept either a Topology or a CljStreamsBuilder.
| .lein-* | ||
| .cpcache | ||
| .nrepl-port | ||
| /.idea |
There was a problem hiding this comment.
This is a convenience for IntelliJ/Cursive users that prevents project files from being committed.
| (.putAll props opts) | ||
| (KafkaStreams. ^Topology (.build ^StreamsBuilder (streams-builder* builder)) | ||
| ^java.util.Properties props)))) | ||
| (defn ^Topology topology |
There was a problem hiding this comment.
This block decouples the creation of the streams app from the creation of the underlying Topology. This is particularly useful for drilling down into the Topology for doing things like accessing the description as well as opening up the way to doing datafy/nav using the active system's topology.
| @@ -1,4 +1,4 @@ | |||
| (ns jackdaw.client-test | |||
| (ns jackdaw.client.partitioning-test | |||
There was a problem hiding this comment.
This is the correct ns name (unless you want to move the file).
Codecov Report
@@ Coverage Diff @@
## master #278 +/- ##
==========================================
+ Coverage 81.16% 81.34% +0.17%
==========================================
Files 41 41
Lines 2586 2589 +3
Branches 153 153
==========================================
+ Hits 2099 2106 +7
+ Misses 334 330 -4
Partials 153 153
Continue to review full report at Codecov.
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #278 +/- ##
==========================================
+ Coverage 81.16% 81.34% +0.17%
==========================================
Files 41 41
Lines 2586 2589 +3
Branches 153 153
==========================================
+ Hits 2099 2106 +7
+ Misses 334 330 -4
Partials 153 153 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3 participants
Checklist