Skip to content

Enable naming global-ktable local store#277

Open
vmatic wants to merge 3 commits into
FundingCircle:masterfrom
Ingemark:master
Open

Enable naming global-ktable local store#277
vmatic wants to merge 3 commits into
FundingCircle:masterfrom
Ingemark:master

Conversation

@vmatic

@vmatic vmatic commented Oct 26, 2020

Copy link
Copy Markdown

The current implementation doesn't support naming the GlobalKTable store. This pull request adds functionality by extending the protocol IStreamsBuilder and adding a new arity to the existing global-ktable function. Implementation follows the same pattern used to name ktable local stores.

@vmatic vmatic requested a review from a team as a code owner October 26, 2020 16:41
@codecov

codecov Bot commented Oct 26, 2020

Copy link
Copy Markdown

Codecov Report

Merging #277 into master will increase coverage by 0.03%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #277      +/-   ##
==========================================
+ Coverage   81.16%   81.20%   +0.03%     
==========================================
  Files          41       41              
  Lines        2586     2596      +10     
  Branches      153      153              
==========================================
+ Hits         2099     2108       +9     
- Misses        334      335       +1     
  Partials      153      153              
Impacted Files Coverage Δ
src/jackdaw/streams/protocols.clj 100.00% <ø> (ø)
src/jackdaw/streams.clj 82.53% <50.00%> (-0.67%) ⬇️
src/jackdaw/streams/interop.clj 82.71% <100.00%> (+2.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daa8387...97cfef7. Read the comment docs.

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.20%. Comparing base (daa8387) to head (97cfef7).
⚠️ Report is 179 commits behind head on master.

Files with missing lines Patch % Lines
src/jackdaw/streams.clj 50.00% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #277      +/-   ##
==========================================
+ Coverage   81.16%   81.20%   +0.03%     
==========================================
  Files          41       41              
  Lines        2586     2596      +10     
  Branches      153      153              
==========================================
+ Hits         2099     2108       +9     
- Misses        334      335       +1     
  Partials      153      153              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants