Skip to content

[#238] Add divert func#236

Open
bn-darindouglass-zz wants to merge 7 commits into
FundingCircle:masterfrom
bn-darindouglass-zz:add-divert-func
Open

[#238] Add divert func#236
bn-darindouglass-zz wants to merge 7 commits into
FundingCircle:masterfrom
bn-darindouglass-zz:add-divert-func

Conversation

@bn-darindouglass-zz

@bn-darindouglass-zz bn-darindouglass-zz commented Apr 2, 2020

Copy link
Copy Markdown

Implements [#238]

Checklist

  • tests
  • updated CHANGELOG (the "unreleased" section)

@bn-darindouglass-zz bn-darindouglass-zz requested a review from a team as a code owner April 2, 2020 20:23
- This transform should be useful for shunting off bad records to
  failure topics or other quick routing tasks
- `sort-by` allows an arbitrary number of (un)ordered diverting

Signed-off-by: Darin Douglass <ddouglass@barracuda.com>
Signed-off-by: Darin Douglass <ddouglass@barracuda.com>
@bn-darindouglass-zz bn-darindouglass-zz changed the title Add divert func [#238] Add divert func Apr 2, 2020
@bn-darindouglass-zz

bn-darindouglass-zz commented Apr 2, 2020

Copy link
Copy Markdown
Author

I'm open to suggestions on naming; primarily, I'm not sure if sort-by indicates well enough what it does.

EDIT: nevermind, I just combined the two functions.

@codecov

codecov Bot commented Apr 2, 2020

Copy link
Copy Markdown

Codecov Report

Merging #236 (6d1f18f) into master (057ef7c) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #236      +/-   ##
==========================================
+ Coverage   80.05%   80.09%   +0.03%     
==========================================
  Files          42       42              
  Lines        2753     2758       +5     
  Branches      157      157              
==========================================
+ Hits         2204     2209       +5     
  Misses        392      392              
  Partials      157      157              
Impacted Files Coverage Δ
src/jackdaw/streams.clj 83.84% <100.00%> (+0.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 057ef7c...6d1f18f. Read the comment docs.

@darin-reify darin-reify mentioned this pull request Aug 23, 2022
2 tasks
@darin-reify

darin-reify commented Aug 23, 2022

Copy link
Copy Markdown

this pr has been replaced by this. feel free to close this pr (as i cannot).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants