Tighten up the test-machine specs#231
Open
cddr wants to merge 4 commits into
Open
Conversation
minimal
reviewed
Feb 13, 2020
99-not-out
previously approved these changes
Feb 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #230 we added helper functions for creating test-commands which helps in cases where the commands are authored using these new functions. @AndreaCrotti commented that it would be nice if we checked that the commands passed to
run-testdid indeed match the specs. This PR includes specs for some of the legacy commands left out of that PR so that we can now properly assert the test-command sequences passed to run-test.To enable spec-checking behaviour during development evaluate
(s/check-asserts true)at the REPL. When this is enabled and you attempt torun-testwith an invalid command sequence, you'll get an exception like soChecklist