Tellows-API: Added option to respect Allowlist#367
Open
jacotec wants to merge 5 commits into
Open
Conversation
In many cases an entry in the Allowlist (manually added or automatically by a dial-out) should make it back as an inbound call anyways, I've added a new option "Allowlist Skip" where you can choose that any numbers on the Allowlist will not be treated as SPAM (and maybe routed to a blackhole destination).
…into release/17.0
In many cases an entry in the Allowlist (manually added or automatically by a dial-out) should always make it back as an inbound call without being SPAM-filtered. FreePBX has no build-in priority for Allowlist calls to bypass SPAM checks in Superfecta. Therefore I've added a new option "Allowlist Skip" where you can choose that any numbers on the Allowlist will not be treated as SPAM (and maybe routed to a blackhole destination).
Contributor
Author
|
Commit tested on two live systems with the latest version here (commit from @moarph , thanks for adding the caller name :-) ). Running stable with and without Allowlist Skip enabled. @kguptasangoma Please kindly review and merge ;-) |
In case Tellows does not return a caller name at all, use as least the call type (like: "Ping call") as name, so you have a bit more information on the phone display than only "SPAM".
Contributor
Author
|
@kapilgupta01 I saw a module update of Superfecta today to V 17.0.6 while three pull requests are waiting since 4 months. Is there any reason they aren't getting merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In many cases an entry in the Allowlist (manually added or automatically by a dial-out) should always make it back as an inbound call without being SPAM-filtered. FreePBX has no build-in priority for Allowlist calls to bypass SPAM checks in Superfecta.
Therefore I've added a new option "Allowlist Skip" where you can choose if any numbers on the Allowlist should not be treated as SPAM (and maybe routed to a blackhole destination).