Skip to content

fix(kds): prevent setInterval leak during fallback polling#70

Merged
khaira777 merged 1 commit into
mainfrom
fix/kds-interval-leak
Jul 9, 2026
Merged

fix(kds): prevent setInterval leak during fallback polling#70
khaira777 merged 1 commit into
mainfrom
fix/kds-interval-leak

Conversation

@khaira777

Copy link
Copy Markdown
Contributor

Summary

Fixes a severe CPU spike (~300%+) and massive context switching in the Electron renderer process caused by an interval leak in the WebSocket fallback logic for the KDS (Kitchen Display System).

Fixes #69

Changes

  • Clears restIntervalRef before setting a new interval in startRestPolling
  • Reorders hooks to prevent TDZ ReferenceError during initial render
  • Adds missing dependencies to useCallback and useEffect arrays
  • Simplifies fallback polling in tryWebSocket

Checklist

  • Tests added/updated for new functionality
  • npm run build passes (no TypeScript errors)
  • npm run lint passes
  • Database migrations are non-destructive (UPDATE, not DROP)
  • Breaking changes documented (if any)
  • Related issue linked above

Screenshots

N/A

@khaira777 khaira777 requested a review from itsbkm as a code owner July 9, 2026 21:22
@khaira777 khaira777 merged commit 0b8a066 into main Jul 9, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Severe CPU spike (300%+) in renderer process due to setInterval leak in KDS page

1 participant