Skip to content

[1.0.0] Paging session limits / request ID validation / misc fixes. - #263

Merged
ChadSikorra merged 7 commits into
FreeDSx:mainfrom
ChadSikorra:upgrade/fixes-pt3
Aug 10, 2026
Merged

[1.0.0] Paging session limits / request ID validation / misc fixes.#263
ChadSikorra merged 7 commits into
FreeDSx:mainfrom
ChadSikorra:upgrade/fixes-pt3

Conversation

@ChadSikorra

Copy link
Copy Markdown
Contributor

A couple mostly misc fixes / guards:

  • Adding a cap on paging sessions so it can't grow indefinitely by one client. Caps at 25. But it's configurable globally and with the normal per entry rules.
  • Fixing message ID validation. My original read of the RFC was incorrect when I first implemented this long ago. It should only validate currently executing operations.
  • Very minor adjustment to reject newlines in attribute use in PDO. This wasn't a security vector really, but should still be rejected.
  • Fixes a read replica race condition on binds. The race condition was very very rare and discovered when I switched forwarding to occur much quicker in tests. Basically we need to re-read the current state of the entry before making a final "is it locked" decision due to sequencing. The alternative is to wrap the whole bind process in a locking transaction, which is a lot more effort for something that is very difficult to hit. I may revisit this.

@codecov

codecov Bot commented Aug 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.06349% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.69%. Comparing base (87358c5) to head (97d3953).

Files with missing lines Patch % Lines
src/FreeDSx/Ldap/ServerOptions.php 66.66% 2 Missing ⚠️
...iner/Provider/ConnectionGraphContainerProvider.php 0.00% 1 Missing ⚠️
...ocol/ServerProtocolHandler/ServerPagingHandler.php 93.33% 1 Missing ⚠️
...dPolicy/Guard/BindStrategy/ReplicaBindStrategy.php 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main     #263   +/-   ##
=========================================
  Coverage     88.69%   88.69%           
- Complexity     6758     6769   +11     
=========================================
  Files           575      575           
  Lines         23350    23397   +47     
=========================================
+ Hits          20711    20753   +42     
- Misses         2639     2644    +5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ChadSikorra
ChadSikorra merged commit 522f7c3 into FreeDSx:main Aug 10, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant