Add an attribute encoding helper. - #15
Merged
Merged
Conversation
This is a tradeoff to keep ASN1 logic in this library, but provide a fast-path helper for LDAP. The performance gains of doing this are enough to warrant it. Attribute encoding on searches is very CPU intensive and this helps for large searches / lots of entries / lots of attributes. This will be used in the LDAP library as a way to optimize server side entry attribute encoding.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15 +/- ##
============================================
+ Coverage 95.13% 95.55% +0.41%
- Complexity 382 399 +17
============================================
Files 24 27 +3
Lines 967 1013 +46
============================================
+ Hits 920 968 +48
+ Misses 47 45 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a tradeoff to keep ASN1 logic in this library, but provide a fast-path helper for LDAP. The performance gains of doing this are enough to warrant it. Attribute encoding on searches is very CPU intensive and this helps for large searches / lots of entries / lots of attributes. This will be used in the LDAP library as a way to optimize server side entry attribute encoding. I've already benchmarked the changes on the LDAP side and it's a roughly 40% encoding savings on searches.