CMake: add install control option#3
Merged
Conversation
Collaborator
Author
|
@kadet1090 @chennes @Lgt2x Can anyone check this one out to unbreak distro builds |
chennes
approved these changes
Jul 4, 2026
chennes
left a comment
chennes
left a comment
Member
There was a problem hiding this comment.
I think this is right. It builds and launches on Windows with LibPack 3.5.3 (the first one that doesn't include Coin and Pivy), in both release and debug modes. As far as I can tell everything worked well in those builds (though I had to also apply the pivy fixes from yesterday so it's always possible I screwed something up!)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
COIN_INSTALLoption, defaulting toON, so embedding projects can build Coin without inheriting Coin's standalone install rules.Motivation:
FreeCAD's bundled Coin build currently pulls in Coin's install rules, which can install standalone Coin files such as
share/Coin/conf/coin-default.cfg,coin-config, pkg-config/CMake package metadata, headers, and data files into the FreeCAD install prefix. Downstream packages that also depend on system Coin can then hit file conflicts.This keeps standalone Coin behavior unchanged by default, while giving embedders an explicit upstream-owned switch.