Grow list rows by the measured wrapped lines of label and subtitle - #37
Merged
itsthisjustin merged 1 commit intoAug 14, 2026
Merged
Conversation
Composes with 58d34b3 (subtitle wrapping): the label above a subtitle can now wrap too — the band takes its measured lines and the (possibly wrapped) subtitle moves below it — covering the title-plus-author list shape where the label carries the long text. Label-only rows now grow by the lines the label actually USES instead of the full maxLines budget: a two-line title in a three-line budget costs one extra line, not two. Adds the host tests both mechanisms were missing: exact-lines label growth, wrapped-subtitle growth, subtitle placement under the wrapped band, and the touch-size gate. Callers that never set maxLines > 1 are untouched. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012Rw7SpQcLpRTfXSSiMizQj
oreglio
force-pushed
the
feat/list-wrapped-label-heights
branch
from
August 14, 2026 10:17
c554739 to
f6f5940
Compare
oreglio
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased on main — this now composes with 58d34b3 (subtitle wrapping) rather than overlapping it:
Running validated on hardware (Xteink X4, CrossInk fork of crosspoint-reader).
test/host/run.sh: 2669 checks; the only failures are the 3 pre-existing ones on main (battery bolt tests still expecting triangles after 2fea991 switched to a pixel bitmap, plus one Line-op count) — unrelated, happy to fix separately.No API change; callers that never set
maxLines > 1are untouched.