refactor(Logic): File layout for LogicGLAlpha/LogicGLBetaMinus - #32
Merged
Conversation
…icGLBetaMinus` Move `TBBMinus`/`LogicGLAlpha`/`LogicA`/`LogicGLBetaMinus`, previously inlined in `LetterlessTrace.lean`, into dedicated `Logic/GLAlpha`, `Logic/GLBetaMinus`, and `Logic/A` modules, mirroring the layout of the other `Logic/*` directories. Rename the long `Alpha`/`Beta` parameter names to `𝔸`/`𝔹` (and `Beta_cofinite` to `𝔹_cofinite`), matching the notation already used by the two-layered `Gentzen/GLAlpha` sequent calculus, and propagate the same renaming to call sites in `GeneralTrace.lean`/`Result.lean`. Co-Authored-By: Claude <noreply@anthropic.com>
…this PR The two-layered Gentzen calculus for LogicGLAlpha is still WIP and doesn't build; keep it untracked on disk for a future PR instead of carrying it (and the resulting excluded/commented-out import) here. Co-Authored-By: Claude <noreply@anthropic.com>
SnO2WMaN
changed the title
LogicGLAlpha/LogicGLBetaMinusLogicGLAlpha and LogicGLBetaMinus
Replace the blackboard-bold 𝔸/𝔹 parameter names introduced by the previous commit with plain X/Y, per feedback. Co-Authored-By: Claude <noreply@anthropic.com>
SnO2WMaN
changed the title
LogicGLAlpha and LogicGLBetaMinusLogicGLAlpha/LogicGLBetaMinus
…rlessTrace, simplify X/Y naming Move `LogicA.eq_provabilityLogicRelativeTo` back out of `Logic/A/Basic.lean` into `LetterlessTrace.lean` (stated via `LogicGLAlpha Set.univ` to avoid the `Logic/A/Basic.lean → GeneralTrace → LetterlessTrace` import cycle), per feedback: this fact belongs alongside `LogicGLAlpha.eq_provabilityLogicRelativeTo`, not in `Logic/A/Basic.lean`. Also simplify the `X`/`Y` naming convention introduced by the previous commit: default to `X` for declarations binding a single trace set (`LogicGLBetaMinus`'s own parameter, `LogicGLBetaMinus.eq_trace`, `LogicGLAlpha.subset_LogicGLBetaMinus`, `eq_LogicGLAlpha_inter_LogicA_LogicGLBetaMinus`), and reserve `Y` for declarations that genuinely need two distinct trace sets simultaneously (`LogicGLAlpha.mono`, `LogicGLBetaMinus.congr`). Co-Authored-By: Claude <noreply@anthropic.com>
… GLAlpha/GLBetaMinus lake shake --keep-public flags these six as redundant now that LetterlessTrace.lean imports Logic/GLAlpha/Basic.lean and Logic/GLBetaMinus/Basic.lean, both of which already public-import them. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TBBMinus/LogicGLAlpha/LogicA/LogicGLBetaMinus, previously inlined at the end ofClassification/LetterlessTrace.lean, into dedicated modules:Logic/GLAlpha/Basic.lean,Logic/GLBetaMinus/Basic.lean, andLogic/A/Basic.lean, mirroring the layout of the otherLogic/*directories.Alpha/Betaparameter names ofLogicGLAlpha/LogicGLBetaMinustoX/Y(andBeta_cofinitetoY_cofinite), and propagate the same renaming to the corresponding local variable names inClassification/GeneralTrace.leanandClassification/Result.lean.sorryand no new warnings.(A related WIP two-layered
Gentzen/GLAlphasequent calculus is being developed separately and is not part of this PR.)Test plan
lake buildgreen for all touched/new modules (Logic/GLAlpha/Basic.lean,Logic/GLBetaMinus/Basic.lean,Logic/A/Basic.lean,Classification/{LetterlessTrace,GeneralTrace,Result}.lean), nosorry, no warnings.just mk-allrun to updateProvabilityLogic.lean.Co-Authored-By: Claude noreply@anthropic.com