refactor(Gentzen): refactor file structures - #31
Merged
Conversation
Split GentzenWithCutProof/GentzenWithCutProvable's syntactic content (inductive, notation, of_without_cut, constructor lemmas, cut, rec) into Basic.lean, and the semantic cut_elimination (via Kripke completeness/soundness) plus its dependents (mdp, ruleLoeb for GL; modalGrz, mdp for Grz) into Kripke.lean, unifying the with-cut sequent calculus placement across logics. WithCut.lean is removed; downstream imports (Hilbert/GL/Grz Basic.lean, Gentzen/A/Basic.lean, Gentzen/A/Kripke.lean) now point at Kripke.lean instead. Co-Authored-By: Claude <noreply@anthropic.com>
…_TFAE to sequent_TFAE Split GentzenWithCutProof/GentzenWithCutProvable's syntactic content (inductive, notation, of_without_cut, constructor lemmas, cut, rec) into D/Basic.lean, matching the GL/Grz layout. D/Kripke.lean's cut-elimination theorem is renamed to ProvableGentzen.of_with_cut with a GentzenWithCutProvable.cut_elimination alias, and semantical_TFAE is renamed sequent_TFAE. D/WithCut.lean is removed; ProvabilityLogic.lean is regenerated via `just mk-all`. Co-Authored-By: Claude <noreply@anthropic.com>
…n.of_with_cut Rename LogicS.semantical_TFAE to LogicS.sequent_TFAE, and move the with-cut cut-elimination corollaries for S and A from GentzenWithCutProvable.cutElimination into (LogicX.)ProvableGentzen.of_with_cut, matching the naming/placement already used for GL, Grz, and D, with a GentzenWithCutProvable.cut_elimination alias kept for compatibility. Co-Authored-By: Claude <noreply@anthropic.com>
SnO2WMaN
changed the title
…oeb to ruleLöb Rename Prop-level ProvableGentzen/GentzenWithCutProvable-bound variables (previously π/π₁/π₂) to h/h₁/h₂ across GL, Grz, A, S, D, and GLPoint3 Basic.lean, keeping π reserved for raw ProofGentzen (bang-notation) terms. Also rename the declaration ruleLoeb to ruleLöb for spelling consistency with the existing Löb usage in this repository. Co-Authored-By: Claude <noreply@anthropic.com>
Apply the same naming convention as ProvabilityLogic/Gentzen/*/Basic.lean: π stays for raw ProofLabelledGentzen (`!`-suffixed) terms, while Prop-level ProvableLabelledGentzen (Nonempty-wrapped, non-`!`) arguments are named h/h₁/h₂. Where renaming created a name clash with an existing h argument (wkRel/wkAnt/wkSuc), rename that argument to hR/hΓ/hΔ. Search.lean is untouched: every π there already binds a raw ProofLabelledGentzen term. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WithCut.leanforGL/Grz/D; syntactic content (theGentzenWithCutProofinductive and its non-semantic lemmas) moves intoBasic.lean, semantic content (cut-elimination and anything depending on it) moves intoKripke.lean.GL/Grz/D/S/A: the theorem is nowProvableGentzen.of_with_cutinKripke.lean, withalias GentzenWithCutProvable.cut_elimination := ProvableGentzen.of_with_cut.semantical_TFAEtosequent_TFAEinD/S(Aalready usedsequent_TFAE).Hilbert/GL/Basic.lean,Hilbert/Grz/Basic.lean, andGentzen/A/{Basic,Kripke}.leanto import.Kripkeinstead of the now-deleted.WithCut.ProvabilityLogic.leanviajust mk-all.No tactic-level proof content was changed; this is purely a file-layout and naming refactor.
Test plan
lake build(full project) green, no new errors/warnings/sorries introducedjust mk-allproduces no diffWithCut.leanfiles or tosemantical_TFAE/GentzenWithCutProvable.cutElimination🤖 Generated with Claude Code