Skip to content

Housekeeping#1108

Merged
tom-englert merged 6 commits into
masterfrom
housekeeping
Jul 4, 2026
Merged

Housekeeping#1108
tom-englert merged 6 commits into
masterfrom
housekeeping

Conversation

@tom-englert

Copy link
Copy Markdown
Member
  • CPM
  • Update dependecies
  • Update XUnit to v3

Copilot AI review requested due to automatic review settings July 3, 2026 13:08

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR performs repository housekeeping to modernize the build/test setup by moving to Central Package Management (CPM), upgrading dependencies (including xUnit v3 + Verify v3), and updating test target frameworks from net6.0 to net10.0.

Changes:

  • Introduce Directory.Packages.props and remove per-project package versions in favor of CPM.
  • Upgrade tests (and smoke tests) to xUnit v3 / Verify.XunitV3 and adjust analyzer test harness calls.
  • Bump test projects and test assemblies from net6.0 to net10.0 (while keeping net48 where applicable).

Reviewed changes

Copilot reviewed 39 out of 39 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
Tests/TypeFilterTests.cs Adds TestResult alias to disambiguate Fody.TestResult usage.
Tests/Tests.csproj Switches to CPM/no-version PackageReferences, xUnit v3 packages, and targets net10.0.
Tests/FSharpTest.cs Adds TestResult alias for Fody.TestResult.
Tests/AssemblyWithInheritanceTests.cs Removes xUnit abstractions using (and relies on updated xUnit v3 setup).
Tests/AssemblyWithDisabledTriggerDependentPropertiesTests.cs Adds TestResult alias for Fody.TestResult.
Tests/AssemblyWithDisabledIsChangedPropertyTests.cs Adds TestResult alias for Fody.TestResult.
Tests/AssemblyWithDisabledInjectOnPropertyNameChangedTests.cs Adds TestResult alias for Fody.TestResult.
Tests/AssemblyWithBaseInDifferentModuleTests.cs Adds TestResult alias for Fody.TestResult.
Tests/AssemblyToProcessTests.cs Adds TestResult alias and removes xUnit abstractions using.
TestAssemblies/AssemblyWithTypeFilter/AssemblyWithTypeFilter.csproj Targets net10.0 instead of net6.0.
TestAssemblies/AssemblyWithStaticOnPropertyNameChanged/AssemblyWithStaticOnPropertyNameChanged.csproj Targets net10.0 instead of net6.0.
TestAssemblies/AssemblyWithStackOverflow/AssemblyWithStackOverflow.csproj Targets net10.0 instead of net6.0.
TestAssemblies/AssemblyWithNonVoidOnPropertyNameChanged/AssemblyWithNonVoidOnPropertyNameChanged.csproj Targets net10.0 instead of net6.0.
TestAssemblies/AssemblyWithInterceptor/AssemblyWithInterceptor.csproj Targets net10.0 instead of net6.0.
TestAssemblies/AssemblyWithInheritance/AssemblyWithInheritance.csproj Targets net10.0 instead of net6.0.
TestAssemblies/AssemblyWithExternalInheritance/AssemblyWithExternalInheritance.csproj Targets net10.0 instead of net6.0.
TestAssemblies/AssemblyWithDisabledTriggerDependentProperties/AssemblyWithDisabledTriggerDependentProperties.csproj Targets net10.0 instead of net6.0.
TestAssemblies/AssemblyWithDisabledIsChangedProperty/AssemblyWithDisabledIsChangedProperty.csproj Targets net10.0 instead of net6.0.
TestAssemblies/AssemblyWithDisabledInjectOnPropertyNameChanged/AssemblyWithDisabledInjectOnPropertyNameChanged.csproj Targets net10.0 instead of net6.0.
TestAssemblies/AssemblyWithBlockingClass/AssemblyWithBlockingClass.csproj Targets net10.0 instead of net6.0.
TestAssemblies/AssemblyWithBeforeAfterInterceptor/AssemblyWithBeforeAfterInterceptor.csproj Targets net10.0 instead of net6.0.
TestAssemblies/AssemblyWithBaseInDifferentModule/AssemblyWithBaseInDifferentModule.csproj Targets net10.0 instead of net6.0.
TestAssemblies/AssemblyWithBase/AssemblyWithBase.csproj Targets net10.0 instead of net6.0.
TestAssemblies/AssemblyWithBadNamedInvoker/AssemblyWithBadNamedInvoker.csproj Targets net10.0 instead of net6.0.
TestAssemblies/AssemblyWithAttributeAndEvent/AssemblyWithAttributeAndEvent.csproj Targets net10.0 instead of net6.0.
TestAssemblies/AssemblyToProcess/AssemblyToProcess.csproj Targets net10.0 instead of net6.0.
TestAssemblies/AssemblyInheritingBadNamedInvoker/AssemblyInheritingBadNamedInvoker.csproj Targets net10.0 instead of net6.0.
TestAssemblies/AssemblyFSharp/AssemblyFSharp.fsproj Updates F# package overrides to use VersionOverride entries.
TestAssemblies/AssemblyExplicitPropertyChanged/AssemblyExplicitPropertyChanged.csproj Targets net10.0 instead of net6.0.
SmokeTest/SmokeTest.csproj Moves to CPM/no-version PackageReferences, xUnit v3 packages, and targets net10.0.
PropertyChanged/PropertyChanged.csproj Moves package versions to CPM (no-version PackageReferences).
PropertyChanged.sln Updates VS version metadata and adds Directory.Packages.props to solution items.
PropertyChanged.Fody/PropertyChanged.Fody.csproj Moves FodyHelpers version to CPM.
PropertyChanged.Fody.Analyzer/PropertyChanged.Fody.Analyzer.csproj Adjusts Roslyn/analyzer package versioning metadata with CPM overrides.
PropertyChanged.Fody.Analyzer/ExtensionMethods.cs Suppresses analyzer warning for a debug-only Console.Beep helper.
PropertyChanged.Fody.Analyzer.Tests/PropertyChanged.Fody.Analyzer.Tests.csproj Moves to CPM/no-version PackageReferences and targets net10.0.
PropertyChanged.Fody.Analyzer.Tests/GlobalUsings.cs Removes an unused global using.
PropertyChanged.Fody.Analyzer.Tests/CodeGeneratorTest.cs Passes xUnit v3 cancellation token into test harness RunAsync.
Directory.Packages.props Adds CPM configuration and centrally defined package versions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread PropertyChanged.sln
Comment thread Tests/AssemblyWithInheritanceTests.cs
Comment thread Tests/AssemblyToProcessTests.cs
Comment thread Tests/Tests.csproj
Comment thread SmokeTest/SmokeTest.csproj
Comment thread TestAssemblies/AssemblyFSharp/AssemblyFSharp.fsproj
@tom-englert tom-englert merged commit 5a2d3bf into master Jul 4, 2026
3 checks passed
@tom-englert tom-englert deleted the housekeeping branch July 4, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants