Skip to content

Add missing jarvis-cli dev dependencies#43

Open
Techris93 wants to merge 1 commit into
Flow-Research:mainfrom
Techris93:codex/fix-jarvis-cli-uv-dev-deps
Open

Add missing jarvis-cli dev dependencies#43
Techris93 wants to merge 1 commit into
Flow-Research:mainfrom
Techris93:codex/fix-jarvis-cli-uv-dev-deps

Conversation

@Techris93

@Techris93 Techris93 commented May 20, 2026

Copy link
Copy Markdown

Summary

  • Add the dev dependencies needed by the existing jarvis-cli test/lint configuration
  • Update uv.lock for the new dev dependency group entries
  • Remove two unused imports surfaced by Ruff

Verification

  • uv sync --dev --frozen
  • uv run ruff check src/jarvis/config tests/unit/config
  • uv run pytest -q tests/unit/config tests/journal/test_capture.py

Summary by CodeRabbit

  • Chores
    • Updated development tooling dependencies configuration.
    • Cleaned up internal imports and removed unused dependencies.

@Konan69

Konan69 commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 6, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Jun 6, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d6a6cc1b-0f89-4806-9ed5-c21836df4d20

📥 Commits

Reviewing files that changed from the base of the PR and between 0fc8435 and af0d719.

⛔ Files ignored due to path filters (1)
  • jarvis-cli/uv.lock is excluded by !**/*.lock
📒 Files selected for processing (3)
  • jarvis-cli/pyproject.toml
  • jarvis-cli/src/jarvis/config/loader.py
  • jarvis-cli/tests/unit/config/test_schema.py
💤 Files with no reviewable changes (1)
  • jarvis-cli/tests/unit/config/test_schema.py

📝 Walkthrough

Walkthrough

This PR updates the project configuration and removes unused imports. The dev dependency group is populated with testing and linting tools, and two unused imports are removed from the config loader module and its test file.

Changes

Cleanup and Configuration Updates

Layer / File(s) Summary
Development tooling dependencies
jarvis-cli/pyproject.toml
Dev dependency group is populated with mypy, pytest, pytest-asyncio, pytest-cov, and ruff.
Unused import cleanup
jarvis-cli/src/jarvis/config/loader.py, jarvis-cli/tests/unit/config/test_schema.py
NotionConfig import is removed from the config loader module, and the unused os import is removed from the test module.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Add missing jarvis-cli dev dependencies' accurately describes the main change in the PR, which adds dev tooling dependencies (mypy, pytest, pytest-asyncio, pytest-cov, ruff) to pyproject.toml.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
⚔️ Resolve merge conflicts
  • Resolve merge conflict in branch codex/fix-jarvis-cli-uv-dev-deps

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants