Death Acidifier Is Optional For Ninja (And Also No Randomization of Ninja and Nukies/LoneOp) - #889
Open
kivdon wants to merge 9 commits into
Open
Death Acidifier Is Optional For Ninja (And Also No Randomization of Ninja and Nukies/LoneOp)#889kivdon wants to merge 9 commits into
kivdon wants to merge 9 commits into
Conversation
…rced in. Signed-off-by: kivdon <kivdon1@gmail.com>
Signed-off-by: kivdon <kivdon1@gmail.com>
kivdon
marked this pull request as ready for review
August 1, 2026 17:32
kivdon
requested review from
M3739,
Mnemotechnician and
SyaoranFox
as code owners
August 1, 2026 17:32
Contributor
Author
|
Tested. |
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: kivdon <kivdon1@gmail.com>
Signed-off-by: kivdon <kivdon1@gmail.com>
Signed-off-by: kivdon <kivdon1@gmail.com>
Signed-off-by: kivdon <kivdon1@gmail.com>
Signed-off-by: kivdon <kivdon1@gmail.com>
Signed-off-by: kivdon <kivdon1@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Removed death acidifier from being automatically implanted from Ninja at spawn.
Put an implanter for the death acidifier in the Ninja's hand at spawn.
I also removed the upcoming change from upstream that would make the Ninja's appearance randomized. And same for Nukies/LoneOp.
Why / Balance
Reducing unwanted round-removal. Sec has a tendency to continue damaging a hostile even after they're Crit. When this happens to the Ninja, the acidifier causes them to gib upon becoming Dead. Or maybe the Ninja got unlucky and had an allergic reaction, or maybe it just simply died to something silly and unavoidable. Whatever the case, if the Ninja dies, it gets instantly round-removed.
Many people dislike this for multiple reasons. Perhaps they were a friendly ninja that was murdered by an overzealous officer (this has happened to me). Perhaps they want to continue their RP, even after being critted/killed and arrested. Whatever the reason, I think the RP is better when you're not forced to be round-removed.
Some people do want to use the death acidifier though, so I made it so an implanter for it should spawn in the Ninja's hand.
Now, it's your choice on whether you want to be round-removed or not.
Also, an upstream merge was going to cause the Ninja's appearance to become randomized, so I commented that out.
We have a number of people who do recurring Ninja characters, and that would've basically eliminated them.
Same thing for Nukies/LoneOp.
Technical details
Just some simple yml changes.
Media
Click to show
This screenshot shows that the freshly spawned Ninja has no implant in it, but holds a death acidifier implanter in its hand.

Here's a LoneOp spawned with my selected character's appearance.

Same thing for an LPO:

Same thing with Nukie ghost role:

Requirements
Licensing:
Breaking changes
Changelog
🆑