Skip to content

Code cleanup and number frames based on their location in the source video - #107

Open
lizardgai4 wants to merge 11 commits into
Firepal:mainfrom
lizardgai4:long_modulators
Open

Code cleanup and number frames based on their location in the source video#107
lizardgai4 wants to merge 11 commits into
Firepal:mainfrom
lizardgai4:long_modulators

Conversation

@lizardgai4

Copy link
Copy Markdown
Contributor

Most of the changes can be replicated by running the following two commands:
python -m black ./*.py
python -m isort ./*.py

The only other changes are in stammer.py, and they are:

  • How frames are numbered and cleaning up the method of reverse enumeration
  • Prevent a rare error where line breaks appear in a frame count string from ffmpeg

lizardgai4 and others added 6 commits August 23, 2026 23:50
Note: I think we should just straight up name frames
as the numbers that they should be, instead of
having a lookup table.
This code is already renaming files, too.

I should really be moving this repo to codeberg.
@lizardgai4
lizardgai4 changed the base branch from main to frames_and_lookup August 28, 2026 03:33
@lizardgai4
lizardgai4 changed the base branch from frames_and_lookup to main August 28, 2026 03:34
@Firepal

Firepal commented Aug 28, 2026

Copy link
Copy Markdown
Owner

Heads up; I'm in the process of splitting up logic into functions and making misc. changes in stammer.py to help me understand this repo I've inherited from ArdenButterfield. This might create quite a merge conflict with this PR.


I sorta like what this does to some of the difficult-to-parse audio matching and video output code. Not a fan of how ffmpeg arguments each have a single line though. Makes it hard to read. We probably should've been using shutil.split...

Btw, this PR is still using long_modulators branch, and something is confusing the GitHub "Rebase and merge" logic with that branch's commit history.
It's considered good form to make a new branch based on main, and then make a PR from that.

@lizardgai4

lizardgai4 commented Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

Okay, I can put these changes into my main branch and redirect this PR to pull from my main

EDIT: I can't change the base branch here. I would have to make a new PR to do it, so I'll keep it as is

EDIT 2: I removed most of Black's changes to stammer.py to avoid most merge conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants