Shadow of War: HDR and more by XgarhontX · Pull Request #157 · Filoppi/Luma-Framework

XgarhontX · 2026-07-19T07:43:16Z

DON'T ACCEPT YET!

Please let @garamond13 review first!

HDR

Tonemap (Reinhard based) extension by derivative. https://www.desmos.com/calculator/stnfdhk9t1
Forces relaunch to use SDR mode for HDR upgrades.
- Tonemap coeffs are botched in HDR mode.
FMVs tied to Scene Paper White.

SR

Allow ignore_upgraded_samplers toggle
- Since I don't notice major benefits with it, and it also changes distant material LOD params.
Toggle for CopyResource() to fix missing bloom and stuff when using Depth of Field.
- Just in case, since it's always broken on my end...

Others

UI & "scene color after tonemap" resources indirect upgraded 16f.
Photo Mode Contrast shader uses RenoDX Contrast instead of whatever they had that clips HDR.
RCAS
Bloom and God Rays sliders.
UI Toggle
Retuned Fire
- Modded a bunch of fire shaders to reduce clipping (from flame color gradient LUT sampling).
- Since it changes style, user can disable (though it just breaks the shaders from compiling rn).

Cleanliness?

I still need to clean up Shaders folder.
I tried to compartmentalize the new stuff. Idk if it's more confusing.
I reformatted so that your DLSS handling code indentation is the same as everything else in Luma.

TODO

Alternative AO.
Fix vanilla TAA artifacts to black for extremely bright pixels.

Luma Tab

Ofc, SDR will hide unused.

Retuned Fire

Off vs On

Obvi, way more impactful in HDR.

garamond13 · 2026-07-19T16:10:48Z

+            device_data.has_drawn_sr = sr_implementations[device_data.sr_type]->Draw(sr_instance_data, native_device_context, draw_data);
+
+            // Copy back to input, fixing missing transparency FXs.
+            if (SRUser::copy_resource) native_device_context->CopyResource(resource_scene.get(), resource_rt.get());


Is this really necessary?
Maybe the issue is how DLSS handles alpha.

If it's that unoptimized to have the branch not execute, the ok, del it. Otherwise, I can't get bloom to show unless I use that on my end.

Could you test copying alpha of the scene to the DLSS output, after DLSS runs. The original TAA copies alpha from the scene to the output.

garamond13 · 2026-07-19T16:28:47Z

I couldn't compile on my end, Luma CB hell.

I don't think having too many namespaces helps with organization and readability. Some is in namespaces, some global (unnamed namespace), some is in struct GameDeviceDataMiddleEarthShadowOfWar, than replication of functions like OnPresent.

Overall if it all works fine (couldn't test on my end, can't compile), it's fine with me.

XgarhontX · 2026-07-19T16:38:38Z

I couldn't compile on my end, Luma CB hell.

I don't think having too many namespaces helps with organization and readability. Some is in namespaces, some global (unnamed namespace), some is in struct GameDeviceDataMiddleEarthShadowOfWar, than replication of functions like OnPresent.

Overall if it all works fine (couldn't test on my end, can't compile), it's fine with me.

I'll clean it up more when I get home. A lot of the namespace meant to be more complicated until I figured out how to reduce. Like DisplayMode used to be way crazier, handling branching between vanilla HDR and SDR mode until I found that HDR mode is beyond repair.

XgarhontX · 2026-07-20T07:26:01Z

I couldn't compile on my end, Luma CB hell.

I thought you included the file already lol, since you had GameCBuffers created already, so I forgot to push vcxproj.

I don't think having too many namespaces helps with organization and readability. Some is in namespaces, some global (unnamed namespace), some is in struct GameDeviceDataMiddleEarthShadowOfWar, than replication of functions like OnPresent.

I removed them. Only the really needed few are there now.

Everything is finalizing for HDR, and it should compile now. (Included FSR src and libs too, though unused.)

I still haven't found why the DLSS bloom missing thing happens.

Discarding the TAA shader leads to similar (though even worse) missing FXs, obviously because output isn't written to.
(Still can't decomp TAA fully but) Letting TAA alpha return 0 or 1 doesn't change anything, at least I didn't notice any.
I'd say just leave the toggle, just in case.

Also, I can combine down all the commits after you've read them

XgarhontX · 2026-07-20T08:36:47Z

@garamond13 If you build, can you check DLSS?
I'm pretty sure it's working, but I can't get the dev overlay to show, idk.

garamond13 · 2026-07-20T18:59:44Z

DLSS works fine for me.
Are you by any chance overriding DLSS with the Nvidia APP?

In shaders you have some .hlsl 1 files.
Luma already has some functions for color encode, decode, etc.

This may be bug with decompiler.
Original: movc r0.w, cb3[0].x, cb2[24].w, l(1.000000)
Decompiled: r0.w = !cb3[0].x ? cb2[24].w : 1;

Some UI suggestions.

Also some UI settings are replicated in shader defines, is that avoidable?

garamond13 · 2026-07-20T19:17:30Z

Strange I decompiled some other shader, and it looks correct.
3Dmigoto v1.3.16
0xE03893F6.ps_5_0.txt

Decompiled one more, more complex shader. It decompiled correctly.

…nded

XgarhontX · 2026-07-21T03:30:22Z

DLSS works fine for me. Are you by any chance overriding DLSS with the Nvidia APP?

It's always the goofy things... smh

In shaders you have some .hlsl 1 files.

Ok, I put them explicitly in a folder "Unused or Broken"

Luma already has some functions for color encode, decode, etc.

Yea, I'm now using them. (It's because I can never remember if it's gamma_srgb_to_linear or srgb_gamma_to_linear.)

This may be bug with decompiler. Original: movc r0.w, cb3[0].x, cb2[24].w, l(1.000000) Decompiled: r0.w = !cb3[0].x ? cb2[24].w : 1;

Yea, all the fire shaders has that. I think I added the ! for them, since it was inverted without.
Still, idk why TAA is not decompiling correctly. It never "anti-alias", like it always chooses new color.

Some UI suggestions.

Ok, I reworded almost all.
I want to keep TAA and 100% warning though. It's already on the lighter side. I was gonna make them colored & pulsing because I've had too many people ask help on why DLSS is not enabled for another mod.
Tab switching is fixed too. (Unpaired ImGui::PushID())
In HDR where there are couple more sections, I think they are warranted.

Also some UI settings are replicated in shader defines, is that avoidable?

I wanted it that way because from my other mods, people tend to completely miss or just dislike that screen.

Most Controversial Change

~~I fixed the missing bloom... somehow. It fixed alongside me accounting for Photo Mode's TAA without Motion Vectors shader. I suspect it's something with the SRV array and the Reset/Release, but idk.~~ nvm, it didn't change anything...Photo Mode works though.
~~Now, Motion Vectors' resource is from the Linearize Depth shader's UAV1. That means there's an additional CSGetUnorderedAccessViews() and TAA's PSGetShaderResources() only gets scene color.~~

XgarhontX · 2026-07-21T03:40:02Z

…SR in Photo Mode.

XgarhontX · 2026-07-21T04:52:19Z

I walked back on the UAV access since MVs generates on paused moving objects, which leads to artefacting.

Now, I'm just passing in a dummy black 1x1 texture for MVs while in Photo Mode.
It smears in movement, but that's not the point of Photo Mode anyways.

…rks!

XgarhontX · 2026-07-22T05:25:44Z

Bruh... what. Metallic armor in rain is completely broken when Upgrade Samplers.
(Apparently, it's only on PUBLISHING for me. DEVELOPMENT works.)

garamond13 · 2026-07-23T22:14:46Z

The game has TAA without motion vectors?
If we don't have MVs in TAA it may be better to not run DLSS/FSR at all? I don't see much point in running them without MVs.

Device resources need to be released at least on device destroy. Also you can use Luma's managed device resources from GameDeviceData struct (struct GameDeviceDataMiddleEarthShadowOfWar).

Could use current Jitter history section as general dev info (FOV, renderer res, etc).
Why not auto update jitters in UI?
Would it be better to call JitterHistory::AddNewToHistory in OnUpdateBufferRegion? Cause currently it will only be called if SR is enabled.

For FSR we should get far plane, near plane and FOV from the game (if we can). Also near and far plane are not set at the moment, I guess it defaults to 0.

In the debug build wrong libs are used, release libs are used instead of debug ones.

XgarhontX · 2026-07-23T22:46:13Z

The game has TAA without motion vectors? If we don't have MVs in TAA it may be better to not run DLSS/FSR at all? I don't see much point in running them without MVs.

It's for Photo Mode. Very useful to have it there.
But come to think, there are some quick transition effects (iirc pausing into Map screen) that also uses.
So, I will detect Photo Mode (though a frame late) and activate it there.

Device resources need to be released at least on device destroy. Also you can use Luma's managed device resources from GameDeviceData struct (struct GameDeviceDataMiddleEarthShadowOfWar).

So I need to empty ManagedResources on swapchain change?

Could use current Jitter history section as general dev info (FOV, renderer res, etc). Why not auto update jitters in UI? Would it be better to call JitterHistory::AddNewToHistory in OnUpdateBufferRegion? Cause currently it will only be called if SR is enabled.

It was just a "whatever" feature. I wanted to see both the changed and raw (which the best place is OnDrawOrDispatch()), in order to find if the game's jitter array is stored somewhere.

For FSR we should get far plane, near plane and FOV from the game (if we can). Also near and far plane are not set at the moment, I guess it defaults to 0.

Honestly, FSR can look worse than TAA 💀.
CPU-side hacking is something I suck at (unless it's stored in some CB?), and FOV also changes rapidly during gameplay, so idk.

In the debug build wrong libs are used, release libs are used instead of debug ones.

Ok let me see, because idk where the template copy/paste is. It doesn't hurt though, right?

garamond13 · 2026-07-24T00:37:30Z

So I need to empty ManagedResources on swapchain change?

If you use Luam's managed resources, only if you need them to change on resolution change. Luma will release them on device destroy. Already have convenient access to them in OnDrawOrDispatch, auto& managed_resources = game_device_data.managed_resources;.

CPU-side hacking is something I suck at (unless it's stored in some CB?), and FOV also changes rapidly during gameplay, so idk.

We should try to get FOV and camera planes from CBs.

Heliumrich · 2026-07-28T13:29:54Z

~~This is amazing ! Even if it seems no DLSS during gameplay :/~~

Are you interested in making a mod for Shadow of Mordor, the first game, later ?
Even if it's "just" HDR and nothing else. This game has no RenoDX mod :(
Well it might be more complex considering the game has no (even broken) vanilla HDR support

XgarhontX · 2026-07-28T14:41:47Z

This is amazing ! Even if it seems no DLSS during gameplay :/

Are you interested in making a mod for Shadow of Mordor, the first game, later ?
Even if it's "just" HDR and nothing else. This game has no RenoDX mod :(
Well it might be more complex considering the game has no (even broken) vanilla HDR support

Yea, it's almost done.

Heliumrich · 2026-08-07T23:27:22Z

Will you try to make DLSS work with resolution scaling ?
Going from buttery smooth 90fps cap (up to 100fps) to 60fps is kinda tough (4K monitor)

I guess I could try another preset, I had nvidia force preset M.
Maybe DLAA with another preset is decent and way cheaper..? (RTX 4080) though FSR3 is still "only" 80fps

Shadow of War: HDR and more

a916c4f

garamond13 reviewed Jul 19, 2026

View reviewed changes

Comment thread Source/Games/Middle-earth Shadow of War/main.cpp

garamond13 reviewed Jul 19, 2026

View reviewed changes

Comment thread Source/Games/Middle-earth Shadow of War/main.cpp Outdated

XgarhontX added 9 commits July 19, 2026 19:33

Shadow of War: Include everything and GameCBuffers

c25ff94

Shadow of War: Del unused shaders

289fac0

Shadow of War: include a bunch of libs

6de25a8

Shadow of War: Clean main

4f2e9ce

Shadow of War: uses global include RCAS

33f5d24

Shadow of War: Reworded SR ImGui Section

c8183bc

Shadow of War: Don't exec SR code if off. Reduced Namespaces.

43f1649

Shadow of War: fixes

a0359a7

Shadow of War: DISABLE_AUTO_DEBUGGER 1

fcc9acc

XgarhontX added 2 commits July 20, 2026 00:47

Shadow of War: Fixed unreadable text color

c4b1935

Shadow of War: Removed duplicated shader

57c91e7

XgarhontX added 9 commits July 20, 2026 15:30

Shadow of War: DLSS Jitter History (DEVELOPMENT)

a35e797

Shadow of War: Fixed ImGui ID pushing

ab5c53b

Shadow of War: Reword user settings

e76a983

Shadow of War: Cleaned Shaders

60eebf4

Shadow of War: Fixed edge cases for rolloff ext

ce6e0e3

Shadow of War: exposed Retuned Fire settings

73e2599

Shadow of War: SR in Photo Mode (when TAA w/o MVs)

0795776

Shadow of War: Exposed Mip LOD bias for user to boost past SR recomme…

7ebcc11

…nded

Shadow of War: removed Photo Mode warning

007e9c7

XgarhontX added 2 commits July 20, 2026 20:44

Shadow of War: typo

e521a2e

Shadow of War: Re-added the CopyResource() fix

28b127b

XgarhontX force-pushed the shadowofwar branch from 1013aaa to 28b127b Compare July 21, 2026 03:53

XgarhontX added 3 commits July 20, 2026 21:47

Shadow of War: No more UAV access for SR. Pass in dummy resource for …

cc372f5

…SR in Photo Mode.

Shadow of War: draw_data.reset

89d569a

Shadow of War: typo

f0bd150

XgarhontX added 6 commits July 21, 2026 09:36

Shadow of War: JitterHistory shows raw from CB

3a12412

Shadow of War: tonemap safer which fixed TAA black

1897e9c

Shadow of War: Removed "needs testing" comment for jitter since it wo…

bae964a

…rks!

Shadow of War: Sampler upgrades default off again. Tooltip to warn user.

348809f

Shadow of War: force DEVELOPMENT Shader Define off

9a9ab6b

Shadow of War: retuned Fire Retuning

a688195

Shadow of War: FSR

31279ce

Uh oh!

Conversation

XgarhontX commented Jul 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

DON'T ACCEPT YET!

HDR

SR

Others

Cleanliness?

TODO

Luma Tab

Retuned Fire

Uh oh!

Uh oh!

garamond13 Jul 19, 2026

Choose a reason for hiding this comment

Uh oh!

XgarhontX Jul 19, 2026

Choose a reason for hiding this comment

Uh oh!

garamond13 Jul 19, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

garamond13 commented Jul 19, 2026

Uh oh!

XgarhontX commented Jul 19, 2026

Uh oh!

XgarhontX commented Jul 20, 2026

Uh oh!

XgarhontX commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

garamond13 commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

garamond13 commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

XgarhontX commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Most Controversial Change

Uh oh!

XgarhontX commented Jul 21, 2026

Uh oh!

XgarhontX commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

XgarhontX commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

garamond13 commented Jul 23, 2026

Uh oh!

XgarhontX commented Jul 23, 2026

Uh oh!

garamond13 commented Jul 24, 2026

Uh oh!

Heliumrich commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

XgarhontX commented Jul 28, 2026

Uh oh!

Heliumrich commented Aug 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

XgarhontX commented Jul 19, 2026 •

edited

Loading

XgarhontX commented Jul 20, 2026 •

edited

Loading

garamond13 commented Jul 20, 2026 •

edited

Loading

garamond13 commented Jul 20, 2026 •

edited

Loading

XgarhontX commented Jul 21, 2026 •

edited

Loading

XgarhontX commented Jul 21, 2026 •

edited

Loading

XgarhontX commented Jul 22, 2026 •

edited

Loading

Heliumrich commented Jul 28, 2026 •

edited

Loading

Heliumrich commented Aug 7, 2026 •

edited

Loading