feat: per-file subtitle sync memory, audio/sub track memory, sub-step buttons - #22
Open
Adventurous-Field319 wants to merge 1 commit into
Conversation
- Extended subtitle delay slider range from +-10s to +-300s - Added sub-step buttons (previous/next subtitle line) to RightControls - Per-file subtitle delay memory: each file stores its own delay, persisted to disk across app restarts (200-file LRU cap) - Per-file audio track memory: selected dub/language track remembered per file - Per-file subtitle track memory: selected subtitle track remembered per file - Fixed sync bleed: switching files no longer carries over previous delay - Fixed race condition: hydration promise ensures disk state loads before restore - Fixed type mismatch: MPV track IDs (number) vs stored strings (String cast) - Fixed Rust UiState struct to persist new fields (MediaTracksState added) - Added mpv_get_property_string Tauri command for reading MPV properties - Verify+retry mechanism for sub-delay (MPV resets it on subtitle track init)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds several quality-of-life improvements for subtitle synchronization and per-file media settings.
Changes
Subtitle sync improvements:
Per-file track memory:
Bug fixes:
numberbut were compared with===against storedstringvalues, causing silent restore failuresUiStatestruct withMediaTracksStateto prevent Serde from silently dropping new fields on saveNew Tauri command:
mpv_get_property_stringto read MPV property values from the frontend (used for verify+retry of sub-delay after subtitle track initialization resets it)Notes
MPV resets
sub-delayafter subtitle tracks finish initializing (which happens afterfile-loadedfires). A verify-and-retry mechanism reads back the actual value at 500ms and 1500ms post-load and re-applies if needed.