fix(detail): page-level vertical scroll + contain description content (0.22.3)#53
Merged
Merged
Conversation
The viewport-pinned layout with independently scrolling grid columns kept breaking (no vertical scroll, stray horizontal scrollbar). Switch the ticket detail page to plain page-level scrolling inside .content-body — drop the 'overflow:hidden' bounded-height override and the per-column overflow-y:auto; toolbar/header/grid stack at natural height and scroll as one. The right rail is now position:sticky so properties/activity stay in view. Contain rendered description content so nothing escapes the card and no horizontal scroll is needed: long unbreakable tokens wrap (overflow-wrap), wide tables scroll inside their own box (display:block; overflow-x:auto). Code blocks and images were already contained.
The TestDetailPageScrollContainment suite pinned the old viewport-height / independent-column-scroll design (content-body overflow:hidden, overflow-y:auto on the columns) — the very scheme that kept breaking. Rewrite it to assert the new invariants: page scrolls via .content-body (no bounded-height override), columns no longer self-scroll, the rail is sticky, and description content is contained (overflow-wrap + responsive tables).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem (reported from browser inspection)
Two issues remained on the focused ticket page after 0.22.2:
.content-body) hadoverflow: hiddenfor the detail page and the bounded-height / per-column-scroll scheme never engaged.Fix
1. Page-level vertical scroll
Stop pinning the detail page to the viewport height. Removed the
.content-body:has(> [data-detail-page]) { overflow: hidden; display:flex }override and the per-columnoverflow-y: auto, so.content-bodykeeps its normaloverflow-y: autoand the whole page scrolls as one — exactly like every other non-board page (and matching the manual fix found in the inspector). Toolbar, header and grid now stack at natural height.The right rail (properties/activity) is now
position: stickyso it stays in view while a long description scrolls past — preserving the "context always visible" intent of the old per-column design without the fragile height chain. (.detail-sidebaron doc pages already uses sticky.)2. Contain description content (no horizontal scroll)
overflow-wrap: break-wordon.detail-section-bodyinstead of widening the column.display: block; overflow-x: auto) rather than pushing the layout wider.overflow-x: auto; images already capped atmax-width: 100%.)Net: nothing leaks past the description card, and no page-level horizontal scrollbar is needed.
Files
detail.css— page-scroll layout + sticky railmarkdown.css— content containment (wrap + responsive tables)Release
Bumps to 0.22.3 + CHANGELOG. Merging to
maintriggers the release workflow (PyPI + GitHub release).Generated by Claude Code