Advanced parenthesis patterns#1046
Conversation
|
Can they be named something cooler? Like Continue and Cessation/Cease? |
|
I'm definitely down to change the names to something better, but I feel like Resumption/Cessation (the names from Hexic) don't really have quite the same vibe as Introspection/Retrospection. Also, we probably shouldn't use Continuation to avoid confusion with jumps and the continuation frame system. |
|
Could be Meditation and Afterthought maybe |
|
There's no page for the nested big introspection mishap. |
Ah, good catch. I'll get that done shortly. |
|
Technically yes? But I think it's a little better from an organizational perspective to keep everything together, especially since making it an If more people think it should be an |
| pattern ?: HexPattern(HexDir.WEST), | ||
| HexAPI.instance().getRawHookI18n(HexAPI.modLoc(when (pattern?.angles) { | ||
| SpecialPatterns.RETROSPECTION.angles -> "close_paren" | ||
| SpecialPatterns.MEDITATION.angles -> "open_n_parens" |
There was a problem hiding this comment.
Meditation never throws now, so I think this part should be removed (correct me if I'm wrong)
There was a problem hiding this comment.
It still throws if you cast it without the proper number argument (see lines 310 and 311)
|
This is neat. I like this. Maybe, though, Meditation could add some given list to the intro/retro that's made? |
NOTE: If/when #1047 gets merged, this will need a pretty substantial rewrite to make use of the new system.
Adds Meditation and Recollection, advanced versions of the standard intro/retro patterns.
Meditation is treated as a normal pattern when inside existing parentheses because there's no way to determine how many new layers it should open. This is kind of a janky solution given that every other pattern in this section of the book works even while nested, but the only alternative would be to prevent using it inside parens altogether.
Recollection pushes the list on top of the depth for convenience, since you're much more likely to need the list as an argument for something (saving it to a focus, adding something with Integration Distillation, etc) than the number.