Update Gradle, Kotlin, and Loom to support Inline 1.2.2#1043
Merged
Conversation
object-Object
approved these changes
May 11, 2026
Member
object-Object
left a comment
object-Object
left a comment
There was a problem hiding this comment.
LGTM, but wondering if we should also bump the versions of the kotlin library mods.
Member
There was a problem hiding this comment.
Do we also need to update the versions for fabric-language-kotlin and kotlinforforge?
Member
There was a problem hiding this comment.
Same here and in mods.toml - should we increase the minimum required kotlin versions?
Member
Author
|
Hmm yeah, probably should update those too |
Robotgiggle
added a commit
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation of the pattern overlay feature added in #879 relies on a method in Inline that was renamed in the 1.2.0 update. Thus, if anyone uses a version of Inline beyond that point with the current version of hex, it will break. This PR updates hex's Inline dependency to the latest version and updates the relevant methods to their new names to prevent that from happening, and also updates a bunch of core libraries which are required for the new Inline version.
Note that if this PR does not get merged before the 0.11.4 release, we should instead change the Inline dependency in
fabric.mod.json(fabric) andmods.toml(forge) to explicitly exclude Inline versions 1.2.0 and onwards.Also note that the new Kotlin version (2.2.21) now gives a bunch of warnings about the use of public
copy()methods on data classes with private constructors, since that functionality will be removed in future versions of Kotlin. More info can be found here and here.