Ruff Check for changed py files - #123
Conversation
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe GitHub Actions workflow for Ruff linting was updated to improve how changed Python files are detected and handled. The logic for determining commit SHAs was corrected, debug outputs were added, multiline file output was improved, and a boolean flag now controls whether Ruff runs, enhancing workflow robustness. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/ruff-check.yml(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.37.1)
.github/workflows/ruff-check.yml
[error] 16-16: trailing spaces
(trailing-spaces)
[error] 23-23: trailing spaces
(trailing-spaces)
[error] 29-29: trailing spaces
(trailing-spaces)
[error] 41-41: trailing spaces
(trailing-spaces)
[error] 44-44: trailing spaces
(trailing-spaces)
[error] 48-48: trailing spaces
(trailing-spaces)
[error] 61-61: trailing spaces
(trailing-spaces)
[error] 69-69: trailing spaces
(trailing-spaces)
[error] 73-73: trailing spaces
(trailing-spaces)
[error] 78-78: no new line character at the end of file
(new-line-at-end-of-file)
🔇 Additional comments (1)
.github/workflows/ruff-check.yml (1)
34-40: Correct SHA selection fixes diff logic – looks goodSwitching to
github.event.pull_request.head.shafor PRs andgithub.shafor pushes resolves the previous off-by-one diff bug.
Implementation is sound and reads clearly.
Solves the issue #71 ,
Fixed multi-line output handling in GitHub Actions using heredoc syntax (<<EOF) instead of simple string concatenation