Maint decoders - #724
Open
AhmetNSimsek wants to merge 6 commits into
Open
Conversation
Introduce Decoder class and streamline how the usage of bytes or file
AhmetNSimsek
added
the
maintenance
AhmetNSimsek
marked this pull request as ready for review
September 1, 2026 13:48
This was referenced Sep 1, 2026
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors retrieval decoders to support both file- and byte-based decoding.
Key changes:
Introduces a
Decoderabstraction withFILEandBYTESinput modes.Allows decoders to define kwargs passed to the underlying reader.
Adds explicit gzip handling:
Preserves meaningful file suffixes in cache filenames.
Moves path-capable formats such as NIfTI, GIFTI, FreeSurfer annotations, HDF5/NWB, NumPy, and tabular data to file-based decoding where appropriate.
Removes unnecessary file → bytes → file roundtrips and enables file-backed/lazy access where supported.
Keeps
find_suitable_decoder()as a backwards-compatible wrapper aroundDecoder.from_filename().Custom
func=callbacks retain the existing byte-based behaviour.