Sec/security hardening#226
Open
FUjr wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR hardens QModem command execution and SMS rendering paths against injection and XSS-style risks.
Changes
qmodem_smsucode RPC command execution:popen()/system()modem_ctrlecho > pathwith file writesio.popen("ls ...")directory listings withnixio.fs.dir()Validation
sh -npassed for modified shell scripts.node --checkpassed forsms-pdu.js.git diff --checkpassed for the security commits.innerHTML.Notes
Lua and ucode syntax checks were not run locally because
lua,luac, anducodeare not installed in this environment.