fix bugs#3
Open
JiangNanMax wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I run your example program of kqueue in Go,and found some bugs.
Sharing my idea with you here.
First, after the kqueue server started, i connect to localhost:8080 by telnet, first connection is OK, kqueue server is correctly accept first connection and echo the msg. But new another connection at the same time, you can see that kqueue server do not accept the connection at all.
The cause of first bug is that you do not set connection to non-blocking after accept, so your code is running in blocking mode and one connection block all other connection, corresponding code is in kqueue.go -> Handle( )
But when i set connection to non-blocking after connection accepted, another problem comes. After first echo, connection is closed, after debuging, i found that you use a for loop in your user-define handler func, you do not need to do so, because epoll/kqueue is event-drive, it will handler the read/write event in event loop, you just need to handle the event once then return, do not need to wait for data in loop again, corresponding code is in main.go