修复MotionBlur的Old模式产生的单行像素消失问题#129
Conversation
|
有变化吗? |
按照上次你提的两个修改意见已经改回去了,第一是把帧混合的采样方式改回去了,第二已经把意外注释的代码取消注释了 |
gaoyu06
left a comment
There was a problem hiding this comment.
Thanks for the PR. I completed an initial code review.
Scope
- src/main/java/top/fpsmaster/features/impl/render/MotionBlur.java (+5/-12)
Review status
- I reviewed the changed files and diff shape.
- If there are behavior changes, please make sure tests or verification steps are included in the PR description.
Notes
- If this changes logic, APIs, state handling, or security-sensitive code, I may follow up with more specific comments after deeper validation.
- If there are already passing checks and the implementation matches the stated intent, this is in a good state for maintainers to continue evaluating.
Automated initial review by Hermes.
gaoyu06
left a comment
There was a problem hiding this comment.
Thanks for the PR. I completed an initial code review.
Scope
- src/main/java/top/fpsmaster/features/impl/render/MotionBlur.java (+5/-12)
Review status
- I reviewed the changed files and diff shape.
- If there are behavior changes, please make sure tests or verification steps are included in the PR description.
Notes
- If this changes logic, APIs, state handling, or security-sensitive code, I may follow up with more specific comments after deeper validation.
- If there are already passing checks and the implementation matches the stated intent, this is in a good state for maintainers to continue evaluating.
Automated initial review by Hermes.
gaoyu06
left a comment
There was a problem hiding this comment.
Thanks for the PR. I completed an initial code review.
Scope
- src/main/java/top/fpsmaster/features/impl/render/MotionBlur.java (+5/-12)
Review status
- I reviewed the changed files and diff shape.
- If there are behavior changes, please make sure tests or verification steps are included in the PR description.
Notes
- If this changes logic, APIs, state handling, or security-sensitive code, I may follow up with more specific comments after deeper validation.
- If there are already passing checks and the implementation matches the stated intent, this is in a good state for maintainers to continue evaluating.
Automated initial review by Hermes.
gaoyu06
left a comment
There was a problem hiding this comment.
Thanks for the PR. I completed an initial code review.
Scope
- src/main/java/top/fpsmaster/features/impl/render/MotionBlur.java (+5/-12)
Review status
- I reviewed the changed files and diff shape.
- If there are behavior changes, please make sure tests or verification steps are included in the PR description.
Notes
- If this changes logic, APIs, state handling, or security-sensitive code, I may follow up with more specific comments after deeper validation.
- If there are already passing checks and the implementation matches the stated intent, this is in a good state for maintainers to continue evaluating.
Automated initial review by Hermes.
gaoyu06
left a comment
There was a problem hiding this comment.
Thanks for the PR. I completed an initial code review.
Scope
- src/main/java/top/fpsmaster/features/impl/render/MotionBlur.java (+5/-12)
Review status
- I reviewed the changed files and diff shape.
- If there are behavior changes, please make sure tests or verification steps are included in the PR description.
Notes
- If this changes logic, APIs, state handling, or security-sensitive code, I may follow up with more specific comments after deeper validation.
- If there are already passing checks and the implementation matches the stated intent, this is in a good state for maintainers to continue evaluating.
Automated initial review by Hermes.
gaoyu06
left a comment
There was a problem hiding this comment.
Thanks for the PR. I completed an initial code review.
Scope
- src/main/java/top/fpsmaster/features/impl/render/MotionBlur.java (+5/-12)
Review status
- I reviewed the changed files and diff shape.
- If there are behavior changes, please make sure tests or verification steps are included in the PR description.
Notes
- If this changes logic, APIs, state handling, or security-sensitive code, I may follow up with more specific comments after deeper validation.
- If there are already passing checks and the implementation matches the stated intent, this is in a good state for maintainers to continue evaluating.
Automated initial review by Hermes.
gaoyu06
left a comment
There was a problem hiding this comment.
Thanks for the PR. I completed an initial code review.
Scope
- src/main/java/top/fpsmaster/features/impl/render/MotionBlur.java (+5/-12)
Review status
- I reviewed the changed files and diff shape.
- If there are behavior changes, please make sure tests or verification steps are included in the PR description.
Notes
- If this changes logic, APIs, state handling, or security-sensitive code, I may follow up with more specific comments after deeper validation.
- If there are already passing checks and the implementation matches the stated intent, this is in a good state for maintainers to continue evaluating.
Automated initial review by Hermes.
gaoyu06
left a comment
There was a problem hiding this comment.
Thanks for the PR. I completed an initial code review.
Scope
- src/main/java/top/fpsmaster/features/impl/render/MotionBlur.java (+5/-12)
Review status
- I reviewed the changed files and diff shape.
- If there are behavior changes, please make sure tests or verification steps are included in the PR description.
Notes
- If this changes logic, APIs, state handling, or security-sensitive code, I may follow up with more specific comments after deeper validation.
- If there are already passing checks and the implementation matches the stated intent, this is in a good state for maintainers to continue evaluating.
Automated initial review by Hermes.
gaoyu06
left a comment
There was a problem hiding this comment.
Thanks for the PR. I completed an initial code review.
Scope
- src/main/java/top/fpsmaster/features/impl/render/MotionBlur.java (+5/-12)
Review status
- I reviewed the changed files and diff shape.
- If there are behavior changes, please make sure tests or verification steps are included in the PR description.
Notes
- If this changes logic, APIs, state handling, or security-sensitive code, I may follow up with more specific comments after deeper validation.
- If there are already passing checks and the implementation matches the stated intent, this is in a good state for maintainers to continue evaluating.
Automated initial review by Hermes.
gaoyu06
left a comment
There was a problem hiding this comment.
Thanks for the PR. I completed an initial code review.
Scope
- src/main/java/top/fpsmaster/features/impl/render/MotionBlur.java (+5/-12)
Review status
- I reviewed the changed files and diff shape.
- If there are behavior changes, please make sure tests or verification steps are included in the PR description.
Notes
- If this changes logic, APIs, state handling, or security-sensitive code, I may follow up with more specific comments after deeper validation.
- If there are already passing checks and the implementation matches the stated intent, this is in a good state for maintainers to continue evaluating.
Automated initial review by Hermes.
gaoyu06
left a comment
There was a problem hiding this comment.
Thanks for the PR. I completed an initial code review.
Scope
- src/main/java/top/fpsmaster/features/impl/render/MotionBlur.java (+5/-12)
Review status
- I reviewed the changed files and diff shape.
- If there are behavior changes, please make sure tests or verification steps are included in the PR description.
Notes
- If this changes logic, APIs, state handling, or security-sensitive code, I may follow up with more specific comments after deeper validation.
- If there are already passing checks and the implementation matches the stated intent, this is in a good state for maintainers to continue evaluating.
Automated initial review by Hermes.
gaoyu06
left a comment
There was a problem hiding this comment.
Thanks for the PR. I completed an initial code review.
Scope
- src/main/java/top/fpsmaster/features/impl/render/MotionBlur.java (+5/-12)
Review status
- I reviewed the changed files and diff shape.
- If there are behavior changes, please make sure tests or verification steps are included in the PR description.
Notes
- If this changes logic, APIs, state handling, or security-sensitive code, I may follow up with more specific comments after deeper validation.
- If there are already passing checks and the implementation matches the stated intent, this is in a good state for maintainers to continue evaluating.
Automated initial review by Hermes.
gaoyu06
left a comment
There was a problem hiding this comment.
Thanks for the PR. I completed an initial code review.
Scope
- src/main/java/top/fpsmaster/features/impl/render/MotionBlur.java (+5/-12)
Review status
- I reviewed the changed files and diff shape.
- If there are behavior changes, please make sure tests or verification steps are included in the PR description.
Notes
- If this changes logic, APIs, state handling, or security-sensitive code, I may follow up with more specific comments after deeper validation.
- If there are already passing checks and the implementation matches the stated intent, this is in a good state for maintainers to continue evaluating.
Automated initial review by Hermes.
gaoyu06
left a comment
There was a problem hiding this comment.
Thanks for the PR. I completed an initial code review.
Scope
- src/main/java/top/fpsmaster/features/impl/render/MotionBlur.java (+5/-12)
Review status
- I reviewed the changed files and diff shape.
- If there are behavior changes, please make sure tests or verification steps are included in the PR description.
Notes
- If this changes logic, APIs, state handling, or security-sensitive code, I may follow up with more specific comments after deeper validation.
- If there are already passing checks and the implementation matches the stated intent, this is in a good state for maintainers to continue evaluating.
Automated initial review by Hermes.
gaoyu06
left a comment
There was a problem hiding this comment.
Thanks for the PR. I completed an initial code review.
Scope
- src/main/java/top/fpsmaster/features/impl/render/MotionBlur.java (+5/-12)
Review status
- I reviewed the changed files and diff shape.
- If there are behavior changes, please make sure tests or verification steps are included in the PR description.
Notes
- If this changes logic, APIs, state handling, or security-sensitive code, I may follow up with more specific comments after deeper validation.
- If there are already passing checks and the implementation matches the stated intent, this is in a good state for maintainers to continue evaluating.
Automated initial review by Hermes.
gaoyu06
left a comment
There was a problem hiding this comment.
Thanks for the PR. I completed an initial code review.
Scope
- src/main/java/top/fpsmaster/features/impl/render/MotionBlur.java (+5/-12)
Review status
- I reviewed the changed files and diff shape.
- If there are behavior changes, please make sure tests or verification steps are included in the PR description.
Notes
- If this changes logic, APIs, state handling, or security-sensitive code, I may follow up with more specific comments after deeper validation.
- If there are already passing checks and the implementation matches the stated intent, this is in a good state for maintainers to continue evaluating.
Automated initial review by Hermes.
gaoyu06
left a comment
There was a problem hiding this comment.
Thanks for the PR. I completed an initial code review.
Scope
- src/main/java/top/fpsmaster/features/impl/render/MotionBlur.java (+5/-12)
Review status
- I reviewed the changed files and diff shape.
- If there are behavior changes, please make sure tests or verification steps are included in the PR description.
Notes
- If this changes logic, APIs, state handling, or security-sensitive code, I may follow up with more specific comments after deeper validation.
- If there are already passing checks and the implementation matches the stated intent, this is in a good state for maintainers to continue evaluating.
Automated initial review by Hermes.
gaoyu06
left a comment
There was a problem hiding this comment.
Thanks for the PR. I completed an initial code review.
Scope
- src/main/java/top/fpsmaster/features/impl/render/MotionBlur.java (+5/-12)
Review status
- I reviewed the changed files and diff shape.
- If there are behavior changes, please make sure tests or verification steps are included in the PR description.
Notes
- If this changes logic, APIs, state handling, or security-sensitive code, I may follow up with more specific comments after deeper validation.
- If there are already passing checks and the implementation matches the stated intent, this is in a good state for maintainers to continue evaluating.
Automated initial review by Hermes.
gaoyu06
left a comment
There was a problem hiding this comment.
Thanks for the PR. I completed an initial code review.
Scope
- src/main/java/top/fpsmaster/features/impl/render/MotionBlur.java (+5/-12)
Review status
- I reviewed the changed files and diff shape.
- If there are behavior changes, please make sure tests or verification steps are included in the PR description.
Notes
- If this changes logic, APIs, state handling, or security-sensitive code, I may follow up with more specific comments after deeper validation.
- If there are already passing checks and the implementation matches the stated intent, this is in a good state for maintainers to continue evaluating.
Automated initial review by Hermes.
gaoyu06
left a comment
There was a problem hiding this comment.
Thanks for the PR. I completed an initial code review.
Scope
- src/main/java/top/fpsmaster/features/impl/render/MotionBlur.java (+5/-12)
Review status
- I reviewed the changed files and diff shape.
- If there are behavior changes, please make sure tests or verification steps are included in the PR description.
Notes
- If this changes logic, APIs, state handling, or security-sensitive code, I may follow up with more specific comments after deeper validation.
- If there are already passing checks and the implementation matches the stated intent, this is in a good state for maintainers to continue evaluating.
Automated initial review by Hermes.
gaoyu06
left a comment
There was a problem hiding this comment.
Thanks for the PR. I completed an initial code review.
Scope
- src/main/java/top/fpsmaster/features/impl/render/MotionBlur.java (+5/-12)
Review status
- I reviewed the changed files and diff shape.
- If there are behavior changes, please make sure tests or verification steps are included in the PR description.
Notes
- If this changes logic, APIs, state handling, or security-sensitive code, I may follow up with more specific comments after deeper validation.
- If there are already passing checks and the implementation matches the stated intent, this is in a good state for maintainers to continue evaluating.
Automated initial review by Hermes.
gaoyu06
left a comment
There was a problem hiding this comment.
Thanks for the PR. I completed an initial code review.
Scope
- src/main/java/top/fpsmaster/features/impl/render/MotionBlur.java (+5/-12)
Review status
- I reviewed the changed files and diff shape.
- If there are behavior changes, please make sure tests or verification steps are included in the PR description.
Notes
- If this changes logic, APIs, state handling, or security-sensitive code, I may follow up with more specific comments after deeper validation.
- If there are already passing checks and the implementation matches the stated intent, this is in a good state for maintainers to continue evaluating.
Automated initial review by Hermes.
gaoyu06
left a comment
There was a problem hiding this comment.
Thanks for the PR. I completed an initial code review.
Scope
- src/main/java/top/fpsmaster/features/impl/render/MotionBlur.java (+5/-12)
Review status
- I reviewed the changed files and diff shape.
- If there are behavior changes, please make sure tests or verification steps are included in the PR description.
Notes
- If this changes logic, APIs, state handling, or security-sensitive code, I may follow up with more specific comments after deeper validation.
- If there are already passing checks and the implementation matches the stated intent, this is in a good state for maintainers to continue evaluating.
Automated initial review by Hermes.
gaoyu06
left a comment
There was a problem hiding this comment.
Thanks for the PR. I completed an initial code review.
Scope
- src/main/java/top/fpsmaster/features/impl/render/MotionBlur.java (+5/-12)
Review status
- I reviewed the changed files and diff shape.
- If there are behavior changes, please make sure tests or verification steps are included in the PR description.
Notes
- If this changes logic, APIs, state handling, or security-sensitive code, I may follow up with more specific comments after deeper validation.
- If there are already passing checks and the implementation matches the stated intent, this is in a good state for maintainers to continue evaluating.
Automated initial review by Hermes.
gaoyu06
left a comment
There was a problem hiding this comment.
Thanks for the PR. I completed an initial code review.
Scope
- src/main/java/top/fpsmaster/features/impl/render/MotionBlur.java (+5/-12)
Review status
- I reviewed the changed files and diff shape.
- If there are behavior changes, please make sure tests or verification steps are included in the PR description.
Notes
- If this changes logic, APIs, state handling, or security-sensitive code, I may follow up with more specific comments after deeper validation.
- If there are already passing checks and the implementation matches the stated intent, this is in a good state for maintainers to continue evaluating.
Automated initial review by Hermes.
gaoyu06
left a comment
There was a problem hiding this comment.
Thanks for the PR. I completed an initial code review.
Scope
- src/main/java/top/fpsmaster/features/impl/render/MotionBlur.java (+5/-12)
Review status
- I reviewed the changed files and diff shape.
- If there are behavior changes, please make sure tests or verification steps are included in the PR description.
Notes
- If this changes logic, APIs, state handling, or security-sensitive code, I may follow up with more specific comments after deeper validation.
- If there are already passing checks and the implementation matches the stated intent, this is in a good state for maintainers to continue evaluating.
Automated initial review by Hermes.
gaoyu06
left a comment
There was a problem hiding this comment.
Thanks for the PR. I completed an initial code review.
Scope
- src/main/java/top/fpsmaster/features/impl/render/MotionBlur.java (+5/-12)
Review status
- I reviewed the changed files and diff shape.
- If there are behavior changes, please make sure tests or verification steps are included in the PR description.
Notes
- If this changes logic, APIs, state handling, or security-sensitive code, I may follow up with more specific comments after deeper validation.
- If there are already passing checks and the implementation matches the stated intent, this is in a good state for maintainers to continue evaluating.
Automated initial review by Hermes.
gaoyu06
left a comment
There was a problem hiding this comment.
Thanks for the PR. I completed an initial code review.
Scope
- src/main/java/top/fpsmaster/features/impl/render/MotionBlur.java (+5/-12)
Review status
- I reviewed the changed files and diff shape.
- If there are behavior changes, please make sure tests or verification steps are included in the PR description.
Notes
- If this changes logic, APIs, state handling, or security-sensitive code, I may follow up with more specific comments after deeper validation.
- If there are already passing checks and the implementation matches the stated intent, this is in a good state for maintainers to continue evaluating.
Automated initial review by Hermes.
gaoyu06
left a comment
There was a problem hiding this comment.
Thanks for the PR. I completed an initial code review.
Scope
- src/main/java/top/fpsmaster/features/impl/render/MotionBlur.java (+5/-12)
Review status
- I reviewed the changed files and diff shape.
- If there are behavior changes, please make sure tests or verification steps are included in the PR description.
Notes
- If this changes logic, APIs, state handling, or security-sensitive code, I may follow up with more specific comments after deeper validation.
- If there are already passing checks and the implementation matches the stated intent, this is in a good state for maintainers to continue evaluating.
Automated initial review by Hermes.
gaoyu06
left a comment
There was a problem hiding this comment.
Thanks for the PR. I completed an initial code review.
Scope
- src/main/java/top/fpsmaster/features/impl/render/MotionBlur.java (+5/-12)
Review status
- I reviewed the changed files and diff shape.
- If there are behavior changes, please make sure tests or verification steps are included in the PR description.
Notes
- If this changes logic, APIs, state handling, or security-sensitive code, I may follow up with more specific comments after deeper validation.
- If there are already passing checks and the implementation matches the stated intent, this is in a good state for maintainers to continue evaluating.
Automated initial review by Hermes.
gaoyu06
left a comment
There was a problem hiding this comment.
Thanks for the PR. I completed an initial code review.
Scope
- src/main/java/top/fpsmaster/features/impl/render/MotionBlur.java (+5/-12)
Review status
- I reviewed the changed files and diff shape.
- If there are behavior changes, please make sure tests or verification steps are included in the PR description.
Notes
- If this changes logic, APIs, state handling, or security-sensitive code, I may follow up with more specific comments after deeper validation.
- If there are already passing checks and the implementation matches the stated intent, this is in a good state for maintainers to continue evaluating.
Automated initial review by Hermes.
gaoyu06
left a comment
There was a problem hiding this comment.
Thanks for the PR. I completed an initial code review.
Scope
- src/main/java/top/fpsmaster/features/impl/render/MotionBlur.java (+5/-12)
Review status
- I reviewed the changed files and diff shape.
- If there are behavior changes, please make sure tests or verification steps are included in the PR description.
Notes
- If this changes logic, APIs, state handling, or security-sensitive code, I may follow up with more specific comments after deeper validation.
- If there are already passing checks and the implementation matches the stated intent, this is in a good state for maintainers to continue evaluating.
Automated initial review by Hermes.
gaoyu06
left a comment
There was a problem hiding this comment.
Thanks for the PR. I completed an initial code review.
Scope
- src/main/java/top/fpsmaster/features/impl/render/MotionBlur.java (+5/-12)
Review status
- I reviewed the changed files and diff shape.
- If there are behavior changes, please make sure tests or verification steps are included in the PR description.
Notes
- If this changes logic, APIs, state handling, or security-sensitive code, I may follow up with more specific comments after deeper validation.
- If there are already passing checks and the implementation matches the stated intent, this is in a good state for maintainers to continue evaluating.
Automated initial review by Hermes.
gaoyu06
left a comment
There was a problem hiding this comment.
Thanks for the PR. I completed an initial code review.
Scope
- src/main/java/top/fpsmaster/features/impl/render/MotionBlur.java (+5/-12)
Review status
- I reviewed the changed files and diff shape.
- If there are behavior changes, please make sure tests or verification steps are included in the PR description.
Notes
- If this changes logic, APIs, state handling, or security-sensitive code, I may follow up with more specific comments after deeper validation.
- If there are already passing checks and the implementation matches the stated intent, this is in a good state for maintainers to continue evaluating.
Automated initial review by Hermes.
gaoyu06
left a comment
There was a problem hiding this comment.
Thanks for the PR. I completed an initial code review.
Scope
- src/main/java/top/fpsmaster/features/impl/render/MotionBlur.java (+5/-12)
Review status
- I reviewed the changed files and diff shape.
- If there are behavior changes, please make sure tests or verification steps are included in the PR description.
Notes
- If this changes logic, APIs, state handling, or security-sensitive code, I may follow up with more specific comments after deeper validation.
- If there are already passing checks and the implementation matches the stated intent, this is in a good state for maintainers to continue evaluating.
Automated initial review by Hermes.
gaoyu06
left a comment
There was a problem hiding this comment.
Thanks for the PR. I completed an initial code review.
Scope
- src/main/java/top/fpsmaster/features/impl/render/MotionBlur.java (+5/-12)
Review status
- I reviewed the changed files and diff shape.
- If there are behavior changes, please make sure tests or verification steps are included in the PR description.
Notes
- If this changes logic, APIs, state handling, or security-sensitive code, I may follow up with more specific comments after deeper validation.
- If there are already passing checks and the implementation matches the stated intent, this is in a good state for maintainers to continue evaluating.
Automated initial review by Hermes.
gaoyu06
left a comment
There was a problem hiding this comment.
Thanks for the PR. I completed an initial code review.
Scope
- src/main/java/top/fpsmaster/features/impl/render/MotionBlur.java (+5/-12)
Review status
- I reviewed the changed files and diff shape.
- If there are behavior changes, please make sure tests or verification steps are included in the PR description.
Notes
- If this changes logic, APIs, state handling, or security-sensitive code, I may follow up with more specific comments after deeper validation.
- If there are already passing checks and the implementation matches the stated intent, this is in a good state for maintainers to continue evaluating.
Automated initial review by Hermes.
gaoyu06
left a comment
There was a problem hiding this comment.
Thanks for the PR. I completed an initial code review.
Scope
- src/main/java/top/fpsmaster/features/impl/render/MotionBlur.java (+5/-12)
Review status
- I reviewed the changed files and diff shape.
- If there are behavior changes, please make sure tests or verification steps are included in the PR description.
Notes
- If this changes logic, APIs, state handling, or security-sensitive code, I may follow up with more specific comments after deeper validation.
- If there are already passing checks and the implementation matches the stated intent, this is in a good state for maintainers to continue evaluating.
Automated initial review by Hermes.
gaoyu06
left a comment
There was a problem hiding this comment.
Thanks for the PR. I completed an initial code review.
Scope
- src/main/java/top/fpsmaster/features/impl/render/MotionBlur.java (+5/-12)
Review status
- I reviewed the changed files and diff shape.
- If there are behavior changes, please make sure tests or verification steps are included in the PR description.
Notes
- If this changes logic, APIs, state handling, or security-sensitive code, I may follow up with more specific comments after deeper validation.
- If there are already passing checks and the implementation matches the stated intent, this is in a good state for maintainers to continue evaluating.
Automated initial review by Hermes.
gaoyu06
left a comment
There was a problem hiding this comment.
Thanks for the PR. I completed an initial code review.
Scope
- src/main/java/top/fpsmaster/features/impl/render/MotionBlur.java (+5/-12)
Review status
- I reviewed the changed files and diff shape.
- If there are behavior changes, please make sure tests or verification steps are included in the PR description.
Notes
- If this changes logic, APIs, state handling, or security-sensitive code, I may follow up with more specific comments after deeper validation.
- If there are already passing checks and the implementation matches the stated intent, this is in a good state for maintainers to continue evaluating.
Automated initial review by Hermes.
gaoyu06
left a comment
There was a problem hiding this comment.
Thanks for the PR. I completed an initial code review.
Scope
- src/main/java/top/fpsmaster/features/impl/render/MotionBlur.java (+5/-12)
Review status
- I reviewed the changed files and diff shape.
- If there are behavior changes, please make sure tests or verification steps are included in the PR description.
Notes
- If this changes logic, APIs, state handling, or security-sensitive code, I may follow up with more specific comments after deeper validation.
- If there are already passing checks and the implementation matches the stated intent, this is in a good state for maintainers to continue evaluating.
Automated initial review by Hermes.
|
Earlier automated review comments were duplicated due to a monitoring bug on our side. Please ignore the repeated review messages above — the automation has been paused and the deduplication logic has been fixed to prevent this from happening again. Sorry for the noise. |
QQ20260412-125525.mp4
修复了开启了动态模糊 old模式后,屏幕中间的单行像素会消失的问题,产生的原因是由于绘制的坐标系混用
(这是对上一个pr的重新提交,对上一次由于使用AI后人工审查不仔细导致的错误感到很抱歉)