setup clean base for Pietro#51
Merged
Merged
Conversation
Contributor
Author
|
@piotor87 Here is an example on how to have a clean setup. |
06203a5 to
d0c1c53
Compare
If the role of a variable is a cross-module contract, then it belongs to kanta.config. Otherwise it belongs to their own module (e.g. engine knobs belong into kanta.engine).
1387eaf to
d61593b
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR that sets up a clean python sub-project
engineinside our existing codebase.TODO
Base structure that takes the Parquet file from the intake stage, get the columns from config, and outputs a Parquet file.
Parallelize the processing step
Put intake config into shared configI think it's better to have the shared config file (
src/kanta/config.py) have only the variables that are meant for cross-module use.Other variables, e.g. chunking knobs, should belong to their own module.
That way the shared config file doesn't turn into a gigantic mess.
🤷
logging
How it works
src/kanta/config.py.enginemodule is made available by having the filesrc/kanta/engine/__init__.pysrc/kanta/engine/__main__.pythe engine imports the injection module and the shared config with:python3 -m kanta.enginewill callsrc/kanta/engine/__main__.py